[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [SCM] Debian package checker branch, master, updated. 2.4.1-8-g2d8538b



"Raphael Geissert" <atomo64@gmail.com> writes:

> +    Lintian::Command::Simple::run('mkdir', '-p', "strings/$dir") == 0
> +	or fail("Failed to create directory 'strings/$dir'\n");

Minor thing, but I'd use File::Path::make_path here.  Although I suppose
it's a wash either way on both simplicity and speed.  I tend to have a
kneejerk dislike of running subcommands, but loading a module is probably
equally slow.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>


Reply to: