Bug#602655: lintian: Please check for missing comma in Uploaders field (must in Policy 5.6.3)

[David Prévot <david@tilapin.org>]

Package: lintian
Version: 2.4.3
Severity: wishlist
Tags: patch

Please,

It would be really nice if Lintian could catch serious bug like #602619.

The naive attached patch permit to do so, but there must be nicer.

Regards

David

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (600, 'unstable'), (500, 'testing'), (500, 'stable'), (150, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.34-1-amd64 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils               2.20.1-15         The GNU assembler, linker and bina
ii  diffstat               1.53-1            produces graph of changes introduc
ii  dpkg-dev               1.15.8.5          Debian package development tools
ii  file                   5.04-5            Determines file type using "magic"
ii  gettext                0.18.1.1-3        GNU Internationalization utilities
ii  intltool-debian        0.35.0+20060710.1 Help i18n of RFC822 compliant conf
ii  libapt-pkg-perl        0.1.24+b1         Perl interface to libapt-pkg
ii  libclass-accessor-perl 0.34-1            Perl module that automatically gen
ii  libipc-run-perl        0.89-1            Perl module for running processes
ii  libparse-debianchangel 1.1.1-2.1         parse Debian changelogs and output
ii  libtimedate-perl       1.2000-1          collection of modules to manipulat
ii  liburi-perl            1.56-1            module to manipulate and access UR
ii  locales                2.11.2-7          Embedded GNU C Library: National L
ii  man-db                 2.5.7-6           on-line manual pager
ii  perl [libdigest-sha-pe 5.10.1-16         Larry Wall's Practical Extraction 

lintian recommends no packages.

Versions of packages lintian suggests:
pn  binutils-multiarch            <none>     (no description available)
pn  libtext-template-perl         <none>     (no description available)
ii  man-db                        2.5.7-6    on-line manual pager

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/lintian/lib/Lintian/Check.pm (from lintian package)

*** /tmp/commit-2ff6f5a_Uploaders_comma.patch
commit 2ff6f5a6f6c036f9e0e97495c275b80d9080dc4f
Author: David Prévot <david@tilapin.org>
Date:   Sat Nov 6 18:15:16 2010 -0400

    Catch missing comma in Uploader field

diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
index 6d8cb36..c3abb22 100644
--- a/lib/Lintian/Check.pm
+++ b/lib/Lintian/Check.pm
@@ -159,7 +159,7 @@ sub check_maintainer {
     if (not $mail) {
         tag "$field-address-missing", $maintainer;
     } else {
-	if (not $malformed and $mail !~ /^[^()<>@,;:\\\"\[\]]+@(\S+\.)+\S+/) {
+	if (not $malformed and $mail !~ /^[^()<>@,;:\\\"\[\]]+@(\S+\.)+\S+/ or $mail =~ m/\s/) {
             tag "$field-address-malformed", $maintainer;
 	}
 	if ($mail =~ /(?:localhost|\.localdomain|\.localnet)$/) {