[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#485705: lintian: doesn't properly detect comma in control file email address quoted strings



* Niels Thykier <niels@thykier.net>, 2011-11-19, 09:04:
It breaks testset/foo++ which has some weird uploaders. Basically it appears to read all of

Yama@gotchi, Josip, I am afraid of spam and think this helps
<no_spam_please AT debian.org>

as a single uploader. I strongly suspect this will break our "uploader has no email"-check (with the exception of said uploader being the last uploader). It probably also complicates some of our other "broken uploader" checks.

For the record: I attached diff of test output.

To be honest, this test is quite contrived and I don't believe that these kind of mistakes in Uploaders happen often enough to care about them in lintian.

--
Jakub Wilk
--- testset/tags.foo++  2011-10-23 21:02:33.111267825 +0200
+++ test-out/tags.foo++    2011-11-20 21:21:14.622462999 +0100
@@ -3,11 +3,8 @@
 E: foo++ source: debian-control-file-uses-obsolete-national-encoding at line 19
 E: foo++ source: malformed-dm-upload-allowed no
 E: foo++ source: uploader-address-is-on-localhost Jeroen van Wolffelaar<jeroen@localhost.localdomain>
-E: foo++ source: uploader-address-malformed I am afraid of spam and think this helps <no_spam_please AT debian.org>
 E: foo++ source: uploader-address-malformed Marc 'HE' Brockschmidt <he@unknown>
-E: foo++ source: uploader-address-malformed Yama@gotchi
-E: foo++ source: uploader-address-missing Josip
-E: foo++ source: uploader-name-missing Yama@gotchi
+E: foo++ source: uploader-address-malformed Yama@gotchi, Josip, I am afraid of spam and think this helps <no_spam_please AT debian.org>
 E: foo++ source: wrong-debian-qa-address-set-as-maintainer Lintian Maintainer <debian-qa@lists.debian.org>
 E: foo++-helper: wrong-debian-qa-address-set-as-maintainer Lintian Maintainer <debian-qa@lists.debian.org>
 E: foo++: debian-changelog-file-contains-invalid-email-address he@unknown
@@ -22,6 +19,5 @@
 W: foo++ source: debian-watch-file-unknown-version 0
 W: foo++ source: uploader-address-looks-weird Jeroen van Wolffelaar<jeroen@localhost.localdomain>
 W: foo++ source: uploader-not-full-name Frank
-W: foo++ source: uploader-not-full-name Josip
 W: foo++: latest-debian-changelog-entry-without-new-date
 W: foo++: readme-debian-contains-invalid-email-address foo@unknown

Reply to: