[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#743453: marked as done (lintian: Detect needless suggests/recommends on libservlet[\d\.]+-java)

Your message dated Wed, 18 Jun 2014 20:28:33 +0200
with message-id <53A1DA51.1010405@thykier.net>
and subject line Re: lintian_2.5.23.1_amd64.changes ACCEPTED into unstable
has caused the Debian Bug report #743453,
regarding lintian: Detect needless suggests/recommends on libservlet[\d\.]+-java
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
743453: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=743453
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.21
Severity: wishlist

Hello,

The attached patch detects if a package suggests/recommends
libservlet[\d\.]+-java.
They are actually useless because managed by the web container
and complexify the transition process.

Thanks,
Sylvestre

-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (500, 'stable-updates'), (500, 'stable'), (300, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages lintian depends on:
ii  binutils                       2.24-4
ii  bzip2                          1.0.6-5
ii  diffstat                       1.58-1
ii  file                           1:5.17-1
ii  gettext                        0.18.3.2-1
ii  hardening-includes             2.5
ii  intltool-debian                0.35.0+20060710.1
ii  libapt-pkg-perl                0.1.29+b1
ii  libarchive-zip-perl            1.30-7
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.36-1
ii  libdpkg-perl                   1.17.6
ii  libemail-valid-perl            1.192-1
ii  libfile-basedir-perl           0.03-1
ii  libipc-run-perl                0.92-1
ii  liblist-moreutils-perl         0.33-1+b2
ii  libparse-debianchangelog-perl  1.2.0-1
ii  libtext-levenshtein-perl       0.06~01-2
ii  libtimedate-perl               2.3000-1
ii  liburi-perl                    1.60-1
ii  man-db                         2.6.6-1
ii  patchutils                     0.3.2-3
ii  perl [libdigest-sha-perl]      5.18.2-2+b1
ii  t1utils                        1.37-2

Versions of packages lintian recommends:
pn  libperlio-gzip-perl             <none>
ii  perl-modules [libautodie-perl]  5.18.2-2

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.17.6
ii  libhtml-parser-perl    3.71-1+b1
pn  libtext-template-perl  <none>
pn  libyaml-perl           <none>
ii  xz-utils               5.1.1alpha+20120614-2

-- no debconf information

>From c88f7abc841ba210ec5121bcd1a06a8874dd9888 Mon Sep 17 00:00:00 2001
From: Sylvestre Ledru <sylvestre@debian.org>
Date: Wed, 2 Apr 2014 22:48:32 +0200
Subject: [PATCH] [SL] Warn that the suggests/recommends on
 libservlet[\d\.]+-java is needless

---
 checks/fields.desc                           | 6 ++++++
 checks/fields.pm                             | 4 ++++
 checks/java.pm                               | 2 +-
 debian/changelog                             | 2 ++
 t/tests/fields-java/debian/debian/control.in | 2 ++
 t/tests/fields-java/tags                     | 2 ++
 6 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/checks/fields.desc b/checks/fields.desc
index 552d0e4..0606246 100644
--- a/checks/fields.desc
+++ b/checks/fields.desc
@@ -1222,3 +1222,9 @@ Info: The implementation of the "Debian Maintainers" GR has changed
  .
  Instead these permissions are granted via "dak-commands" files.
 Ref: https://lists.debian.org/debian-devel-announce/2012/09/msg00008.html
+
+Tag: needless-suggest-recommend-libservlet-java
+Severity: normal
+Certainty: certain
+Info: Package should not suggest of recommend libservlet-java
+ This is going to be handle by the web container.
diff --git a/checks/fields.pm b/checks/fields.pm
index 0619349..bc44729 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -804,6 +804,10 @@ sub run {
                         && $d_pkg eq 'packaging-dev'
                         && !$info->is_pkg_class('any-meta'));
 
+                    tag 'needless-suggest-recommend-libservlet-java', "$d_pkg"
+                      if ( ( $field eq 'recommends' || $field eq 'suggests')
+                        && $d_pkg =~ m/libservlet[\d\.]+-java/);
+
                     tag 'needlessly-depends-on-awk', $field
                       if ( $d_pkg eq 'awk'
                         && !$d_version->[0]
diff --git a/checks/java.pm b/checks/java.pm
index 4ed60cd..e47e62d 100644
--- a/checks/java.pm
+++ b/checks/java.pm
@@ -222,7 +222,7 @@ sub run {
         tag 'missing-classpath', join(', ', @java_lib_depends);
     }
 
-    if (!$has_public_jars && $pkg =~ /^lib[^\s,]+-java$/ && $pkg !~ /^lib.*maven.*plugin.*java$/) {
+    if (!$has_public_jars && $pkg =~ /^lib[^\s,]+-java$/ && $pkg !~ /^lib.*maven.*plugin.*/) {
         # Skip this warning if the package name indicates that it is a maven plugin.
 
         # Skip this if it installs a symlink in usr/share/java
diff --git a/debian/changelog b/debian/changelog
index f11dfd8..17b5451 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -15,6 +15,8 @@ lintian (2.5.22.2) UNRELEASED; urgency=medium
     + [SL] Catch uses of Java8 byte code
     + [SL] Do not trigger a warning when a jar is not in /usr/share/java and
       the package name matches lib.*maven.*plugin.*java
+    + [SL] Warn that the suggests/recommends on libservlet[\d\.]+-java is
+      needless
 
  -- Bastien Roucariès <roucaries.bastien+debian@gmail.com>  Mon, 31 Mar 2014 18:52:04 +0200
 
diff --git a/t/tests/fields-java/debian/debian/control.in b/t/tests/fields-java/debian/debian/control.in
index 5125554..7c068b0 100644
--- a/t/tests/fields-java/debian/debian/control.in
+++ b/t/tests/fields-java/debian/debian/control.in
@@ -11,6 +11,8 @@ Depends: $\{misc:Depends\},
          default-jre-headless | java-runtime-headless |
          java2-runtime-headless | kaffe | gcj-jdk |
          openjdk-6-jre | gcj-4.5-jre
+Suggests: libservlet2.5-java
+Recommends: libservlet3.0-java
 Description: {$description}
  This is a test package designed to exercise some feature or tag of
  Lintian.  It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/fields-java/tags b/t/tests/fields-java/tags
index 77ba9af..1486627 100644
--- a/t/tests/fields-java/tags
+++ b/t/tests/fields-java/tags
@@ -6,3 +6,5 @@ W: fields-java source: build-depends-on-specific-java-doc-package openjdk-6-doc
 W: fields-java source: virtual-package-depends-without-real-package-depends build-depends: java-compiler
 W: libfields-java-java-doc: depends-on-specific-java-doc-package recommends
 W: libfields-java-java: needless-dependency-on-jre
+W: libfields-java-java: needless-suggest-recommend-libservlet-java libservlet2.5-java
+W: libfields-java-java: needless-suggest-recommend-libservlet-java libservlet3.0-java
-- 
1.9.0.279.gdc9e3eb

--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 2.5.23.1

Hi,

The bug you reported against Lintian has been fixed in the newly
uploaded version of Lintian (v2.5.23.1).

Due to a mistake on my part, this bug did not get closed automatically
as a part of the upload of Lintian 2.5.23.1.  Therefore, I am closing
this manually now.

For the actual changes please see the changelog or the message below.
After the changes, you will also find the checksums of the uploaded files.

Enjoy,
~Niels

Changes since the last upload:
> Format: 1.8
> Date: Wed, 18 Jun 2014 06:39:15 +0200
> Source: lintian
> Binary: lintian
> Architecture: source all
> Version: 2.5.23.1
> Distribution: unstable
> Urgency: medium
> Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
> Changed-By: Niels Thykier <niels@thykier.net>
> Description:
>  lintian    - Debian package checker
> Closes: 663155 711193 737867 742693 743384 743446 743453 743754 743840 744981 745152 745568 745802 746305 746362 746563 746656 746744 747407 747439 748167 748375 748421 748881
> Changes:
>  lintian (2.5.23.1) unstable; urgency=medium
>  .
>    * debian/rules:
>      + [NT] Avoid regenerating po4a files if not needed.
>    * debian/source/lintian.overrides:
>      + [NT] Add overrides for false-positive "evil JSON" license
>        problem, which is triggered by the current Lintian on the
>        FTP master host.
>  .
>  lintian (2.5.23) unstable; urgency=medium
>  .
>    * Summary of tag changes:
>      + Added:
>        - init.d-script-depends-on-all-virtual-facility
>        - maven-plugin-in-usr-share-java
>        - needless-suggest-recommend-libservlet-java
>        - pre-depends-directly-on-multiarch-support
>        - quilt-series-without-trailing-newline
>        - source-contains-prebuilt-sphinx-documentation
>  .
>    * checks/binaries.{desc,pm}:
>      + [NT] Apply patch from Samuel Bronson to improve the
>        description of the debug-symbols-directly-in-usr-lib-debug
>        tag.
>      + [BR] Extend eglibc whitelist to glibc.  (Closes: #748881).
>    * checks/changelog-file.pm:
>      + [BR] Allow to sid for experimental to unstable comment.
>        (Closes: #747407).
>    * checks/control.{desc,pm}:
>      + [BR] Apply patch from Helmut Grohne to warn about
>        Pre-Depends: multiarch-support in debian/control.
>        (Closes: #747439).
>    * checks/cruft.{desc,pm}:
>      + [BR] Detect sphinx generated documentation and avoid
>        a false positive for minified javascript and missing sources.
>        (Closes: #742693).
>      + [BR] Do not remove newline with c++ comments.  Fix a false
>        positive.
>      + [BR] Fix a GFDL detection false positive in texlive.  Thanks
>        to Norbert Preining.  (Closes: #743754).
>      + [BR] Fix another false positives in GFDL detection.
>      + [BR] Fix a false positive for source-is-missing for
>        deployJava.js.  (Closes: #745152).
>      + [BR] Fix a false positive for GFDL detection in
>        soundjuicer.  (Closes: #748375).
>      + [BR] Fix a false positive for source-is-missing in e2fsprogs.
>        (Closes: #748421).
>    * checks/files.pm:
>      + [BR] Use Lintian::Data for detecting embedded library.
>      + [BR] Add context in embedded lib tagging.
>      + [BR] Avoid to warn on bookmark link.  (Closes: #746656).
>    * checks/fields.{desc,pm}:
>      + [NT] Apply patch from Johannes Schauer to rename "notest"
>        build-profile to "nocheck".  (Closes: #743840)
>      + [NT] Support giving replacements for obsolete packages.
>      + [NT] Fix a bug with versioned dependencies on obsolete
>        packages with non-obsolete alternatives.
>    * checks/infofiles.desc:
>      + [NT] Apply patch from Samuel Bronson to improve some of
>        the examples.
>      + [NT] Apply patch from Don Armstrong to ignore jpg/jpeg images
>        beneath /usr/share/info.  (Closes: #748167)
>    * checks/init.d.{desc,pm}:
>      + [BR] Detect $all virtual dependency in legacy init scripts.
>        Thanks to Holger Levsen.  (Closes: #737867).
>    * checks/java.{desc,pm}:
>      + [SL] Do not trigger a warning when a jar is not in
>        /usr/share/java and the package name matches.  (Closes: #746744).
>        lib.*maven.*plugin.*java.  (Closes: #743446).
>      + [SL] Catch uses of Java8 byte code.  (Closes: #743384).
>      + [SL] Warn that the suggests/recommends on libservlet[\d\.]+-java is
>        needless (Closes: #743453)
>      + [SL] missing-classpath should be disabled on Java binaries
>      + [NT] Exclude some jar files from "codeless-jar" tag based
>        on the basename of the jar file.  This is intended to
>        reduce the number of codeless jars for source/doc jars in
>        eclipse(-based) packages.
>    * checks/patch-systems.{desc,pm}:
>      + [BR] Warn against trailing newline in debian/patches/series.
>        (Closes: #746362).
>    * checks/source-copyright.pm:
>      + [NT] Permit the use of "https://"; in DEP-5 format URIs even
>        if the policy suggests that they have to use "http://";.
>        (Closes: #744981)
>    * checks/testsuite.pm:
>      + [JW] Add new restrictions for DEP-8 tests.  (Closes: #746305)
>  .
>    * data/binary/embedded-libs:
>      + [RG] Detect embedded copies of lcms, lcms2, libmms, libminiupnpc,
>        libupnp, and libyaml, polarssl.
>      + [RG] Don't detect mariadb as embedder of mysql.
>      + [BR] Detect libidn*, and libsrtp.
>      + [NT] Apply patch from Samuel Bronson to detect mpfr and gmp.
>      + [BR] Extend eglibc whitelist to glibc.
>    * data/cruft/non-distributable-files:
>      + [BR] Add a file comes from the Novell libc Software Development
>        Kit.  (Closes: #745802)
>    * data/cruft/non-free-files:
>      + [BR] Add all profiles from icc-profiles non free package.
>      + [BR] Add icc profiles from Adobe.
>      + [BR] Add icc profiles from http://www.color.org/srgbprofiles.xalter.
>      + [BR] Add Apple icc profile: Color LCD Calibrated, Copyright
>        Apple Computer, Inc., 2003
>      + [BR] Add old srgb profile from HP: IEC 61966-2.1 Default RGB
>        colour space - sRGB, Copyright (c) 1998 Hewlett-Packard Company
>    * data/fields/obsolete-packages:
>      + [NT] Add hardening-includes and hardening-wrapper on request of
>        Thijs Kinkhorst.  (Closes: #711193)
>      + [NT] Add python-support on request of Luca Falavigna.
>        (Closes: #746563)
>    * data/java/constants:
>      + [SL] introduce this file to specify JDK values
>    * data/scripts/maintainer-script-bad-command:
>      + [BR] Avoid a false positive for
>        maintainer-script-should-not-use-update-alternatives-set.
>        (Closes: #745568).
>  .
>    * debian/control:
>      + [NT] Add Build-Depends on po4a.
>    * debian/lintian.install:
>      + [NT] Install translations.
>    * debian/{lintian.,source/}lintian-overrides:
>      + [NT] Add overrides for using hardening-includes.
>    * debian/rules:
>      + [NT] Add rules for handling translations.
>      + [NT] Run dh_lintian during binary-indep target.
>  .
>    * frontend/lintian{,-info}:
>      + [NT] Use localized version of tag descriptions.
>        (Closes: #663155)
>  .
>    * lib/Lintian/{CheckScript,Profile}.pm:
>      + [NT] Add support for translations of tag descriptions.
>  .
>    * po4a:
>      + [NT] New directory for translations.
>  .
>    * private/private/gen-po4a-conf:
>      + [NT] New file.
>  .
>    * README:
>      + [NT] Document how to make and contribute translations.



On 2014-06-18 20:19, Debian FTP Masters wrote:
> 
> 
> Accepted:
> 
> Format: 1.8
> Date: Wed, 18 Jun 2014 06:39:15 +0200
> Source: lintian
> Binary: lintian
> Architecture: source all
> Version: 2.5.23.1
> Distribution: unstable
> Urgency: medium
> Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
> Changed-By: Niels Thykier <niels@thykier.net>
> Description:
>  lintian    - Debian package checker
> Changes:
>  lintian (2.5.23.1) unstable; urgency=medium
>  .
>    * debian/rules:
>      + [NT] Avoid regenerating po4a files if not needed.
>    * debian/source/lintian.overrides:
>      + [NT] Add overrides for false-positive "evil JSON" license
>        problem, which is triggered by the current Lintian on the
>        FTP master host.
> Checksums-Sha1:
>  dafbadc6a28e5d5a053be9be676ed29ffa2df931 2701 lintian_2.5.23.1.dsc
>  cee14dc5d8c223635f1af99732ba5f270eeb1e10 1114872 lintian_2.5.23.1.tar.xz
>  8e53deea72c23ac0f509343681bc0197e467b4e2 763680 lintian_2.5.23.1_all.deb
> Checksums-Sha256:
>  6b9d92ad810bec4a129e2af044e9a00e29cc73f1d0a67bbbc035c3176d548247 2701 lintian_2.5.23.1.dsc
>  158bceb42cfdab01ea6dc0fa2e40ff28de9da9ee7c7ec8f0a0edccec2f83c9d7 1114872 lintian_2.5.23.1.tar.xz
>  c058a9e8198257ba266d19f7b9e8608cc99c84b7ce75c1874d7892ce3d8b39e7 763680 lintian_2.5.23.1_all.deb
> Files:
>  c83d3e9618bbcd37198c8f3e2bdb6145 763680 devel optional lintian_2.5.23.1_all.deb
>  39847a62d6a4f7d8adb9556ffd74c384 2701 devel optional lintian_2.5.23.1.dsc
>  b92dae0f31ad2ad464b412050acdcf98 1114872 devel optional lintian_2.5.23.1.tar.xz
> 
> 
> 
> Thank you for your contribution to Debian.
>

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
Reply to: