[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798900: lintian: false positive: source-is-missing for non-minified JS files



On Thu, Sep 17, 2015 at 9:36 AM, Ole Streicher <olebole@debian.org> wrote:
> control: affects -1 python-astropy
>
> Same for astropy; also probably because of a long line:
>
> http://lintian.debian.org/maintainer/debian-astro-maintainers@lists.alioth.debian.org.html#python-astropy
>
> Questioned source file:
>
> https://sources.debian.net/src/python-astropy/1.0.4-1/astropy/extern/js/jquery.dataTables.js
>
> The heuristics is obviously wrong.
>
> IMO, if there is a good chance for false positives, this
> tag should not be marked as "Error", but as "Experimental".

patch are welcome.

The current algorithm is:
- if line > 1024 => minified
- else
     remove comments, remove idention. Line > 256 => minified.

In your case they are a line > 1024.... Likely the
/*globals $,

Are you sure this line was generated by hand ? I think this line was
generated by a script and thus this file is not really the prefered
source of modification (it is bordeline).

Bastien
> Would you change that until there is a better test here?
>
> Best regards
>
> Ole
>


Reply to: