[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#797532: marked as done (Please checks for /build and /tmp/buildd in dir-or-file-in-build-tree)

Your message dated Mon, 05 Oct 2015 21:21:51 +0000
with message-id <E1ZjDCh-0003M1-PO@franck.debian.org>
and subject line Bug#797532: fixed in lintian 2.5.38
has caused the Debian Bug report #797532,
regarding Please checks for /build and /tmp/buildd in dir-or-file-in-build-tree
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
797532: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797532
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.5.36.1
Severity: wishlist
Tags: patch
X-Debbugs-CC: 797466@bugs.debian.org

On Mon, Aug 31, 2015 at 01:17:36PM +0200, Jakub Wilk wrote:
> * Niels Thykier <niels@thykier.net>, 2015-08-31, 12:55:
> >lindsay.d.o:/srv/lintian.debian.org/history/tags/<tag-name>.dat
> 
> Aren't those all false positives from #720910?
> 
> >>I'm still curious to know how could it happen.
> >
> >I do not remember how or what happened.  I can trace the tag back to
> >#678857, which includes Andreas Beckmann quoting me from IRC:
> >
> >"""
> ><nthykier> we occasially [sic!] also see buildd paths as well
> >"""
> 
> Perhaps by buildd paths you meant /build (or /tmp/buildd)? I can image that
> these can appear in debs easily by mistake.

Yes, please add /build and /tmp/buildd to this check, where the actual
builds happen inside the chroots.

Patch attached.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  http://mapreri.org                              : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

From 9ac5395e1f5173993ce7b870a21b0da699068180 Mon Sep 17 00:00:00 2001
From: Mattia Rizzolo <mattia@mapreri.org>
Date: Mon, 31 Aug 2015 11:40:14 +0000
Subject: [PATCH] checks/files.pm: also checks for /build and /tmp/buildd in
 dir-or-file-in-build-tree

---
 checks/files.pm                                | 4 +++-
 debian/changelog                               | 3 +++
 t/tests/files-foo-in-bar/debian/debian/install | 2 ++
 t/tests/files-foo-in-bar/tags                  | 6 ++++++
 4 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/checks/files.pm b/checks/files.pm
index b816ed8..97c4885 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -955,7 +955,9 @@ sub run {
         # build directory
         elsif ($fname =~ m,^var/cache/pbuilder/build/.,
             or $fname =~ m,^var/lib/sbuild/.,
-            or $fname =~ m,^var/lib/buildd/.,) {
+            or $fname =~ m,^var/lib/buildd/.,
+            or $fname =~ m,^build/.,
+            or $fname =~ m,^tmp/buildd.,) {
             unless ($source_pkg eq 'sbuild') {
                 tag 'dir-or-file-in-build-tree', $file;
             }
diff --git a/debian/changelog b/debian/changelog
index 1012308..015febe 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -26,6 +26,9 @@ lintian (2.5.37) UNRELEASED; urgency=medium
     + [JW] Use "an" (instead of "a") before "HTTP".
     + [NT] Assert that -dbgsym packages are in the "debug" section.
       Thanks to Jean-Michel Vourgère for reporting the issue.
+  * checks/files.pm:
+    + Apply patch from Mattia Rizzolo to also check for files in /build and
+      /tmp/buildd in dir-or-file-in-build-tree
   * checks/scripts.pm:
     + [BR] Fix Unescaped left brace in regex.  (Closes: #788926)
   * checks/version-substvars.pm:
diff --git a/t/tests/files-foo-in-bar/debian/debian/install b/t/tests/files-foo-in-bar/debian/debian/install
index af63a20..886b7fe 100644
--- a/t/tests/files-foo-in-bar/debian/debian/install
+++ b/t/tests/files-foo-in-bar/debian/debian/install
@@ -46,6 +46,8 @@ bar etc/opt
 bar var/cache/pbuilder/build
 bar var/lib/sbuild
 bar var/lib/buildd
+bar buildd/dir/foo
+bar tmp/buildd/dir/foo
 bar etc/dhcp3
 
 Bar.pm usr/lib/perl5/Foo
diff --git a/t/tests/files-foo-in-bar/tags b/t/tests/files-foo-in-bar/tags
index 488c306..5616722 100644
--- a/t/tests/files-foo-in-bar/tags
+++ b/t/tests/files-foo-in-bar/tags
@@ -12,6 +12,10 @@ E: files-foo-in-bar: dir-or-file-in-run run/foo/
 E: files-foo-in-bar: dir-or-file-in-run run/foo/bar
 E: files-foo-in-bar: dir-or-file-in-srv srv/foo/
 E: files-foo-in-bar: dir-or-file-in-srv srv/foo/bar
+E: files-foo-in-bar: dir-or-file-in-tmp tmp/buildd/
+E: files-foo-in-bar: dir-or-file-in-tmp tmp/buildd/dir/
+E: files-foo-in-bar: dir-or-file-in-tmp tmp/buildd/dir/foo/
+E: files-foo-in-bar: dir-or-file-in-tmp tmp/buildd/dir/foo/bar
 E: files-foo-in-bar: dir-or-file-in-tmp tmp/foo/
 E: files-foo-in-bar: dir-or-file-in-tmp tmp/foo/bar
 E: files-foo-in-bar: dir-or-file-in-var-lock var/lock/foo/
@@ -27,6 +31,7 @@ E: files-foo-in-bar: file-in-usr-lib-site-python usr/lib/site-python/foo/bar
 E: files-foo-in-bar: file-in-usr-local usr/local/foo/bar
 E: files-foo-in-bar: nested-examples-directory usr/share/doc/files-foo-in-bar/examples/examples/
 E: files-foo-in-bar: non-standard-dir-in-var var/foo/
+E: files-foo-in-bar: non-standard-toplevel-dir buildd/
 E: files-foo-in-bar: non-standard-toplevel-dir emul/
 E: files-foo-in-bar: package-contains-mime-file-outside-package-dir usr/share/mime/foo/
 E: files-foo-in-bar: package-contains-mime-file-outside-package-dir usr/share/mime/foo/bar
@@ -58,6 +63,7 @@ E: files-foo-in-bar: udev-rule-in-etc etc/udev/rules.d/bar
 W: files-foo-in-bar: debug-package-should-be-named-dbg usr/lib/debug/bar
 W: files-foo-in-bar: executable-not-elf-or-script bin/foo/bar
 W: files-foo-in-bar: executable-not-elf-or-script usr/bin/foo/bar
+W: files-foo-in-bar: file-in-unusual-dir buildd/dir/foo/bar
 W: files-foo-in-bar: file-in-unusual-dir emul/bar
 W: files-foo-in-bar: file-in-unusual-dir usr/foo/bar
 W: files-foo-in-bar: file-in-unusual-dir usr/local/foo/bar
-- 
2.5.1

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: lintian
Source-Version: 2.5.38

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 797532@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 05 Oct 2015 22:10:31 +0200
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.38
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 lintian    - Debian package checker
Closes: 756722 790739 795275 796815 797466 797532 797555 798736 798799 799082 799467 799914
Changes:
 lintian (2.5.38) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - command-in-menu-file-and-desktop-file
       - misspelled-closes-bug
 .
   * checks/binaries.desc:
     + [NT] Update description of a tag now that debhelper properly
       strips static libraries.
     + [JW] Relax the regular expression used to used to recognize
       architecture-specific paths to avoid false positive
       arch-dependent-file-not-in-arch-specific-directory in Python debug
       packages.  Thanks to Matthias Klose for the bug report.
       (Closes: #795275)
   * checks/changelog-files.{desc,pm}:
     + [BR] Detect misspelled Closes in changelog file (Closes: #798799)
   * checks/files.{desc,pm}:
     + [AB] Apply patch by Mattia Rizzolo to also check for files in /build
       and /tmp/buildd in dir-or-file-in-build-tree.  (Closes: #797532)
     + [NT] Rewrite the description for dir-or-file-in-build-tree.  Thanks
       to Chris Lamb and Jakub Wilk for pointing out issues with the
       original description.  (Closes: #797466)
     + [BR] Detect pagead2.
     + [BR] Fix false positive privacy-breach-* for alternate link tag
       with type application/rdf+xml.  (Closes: #799914).
   * checks/obsolete-sites.pm:
     + [AB] Stop at <>, $, or " when emitting URLs as tag parameter.
   * checks/menu-format.{desc,pm}:
     + [NT] Check for menu files used to provide a command also listed in
       a desktop file.  This tag is based on the verdict in
       [CTTE #741573].
   * checks/rules.desc:
     + [NT,JW] Improve the wording of one of the tags based on feedback
       from Chris Lamb.  (Closes: #796815)
   * checks/scripts.desc:
     + [NT] Apply patch from Chris Lamb to fix a grammatical issue in a
       tag description.  (Closes: #797555)
   * checks/shared-libs.pm:
     + [JW] Fix false positive dev-pkg-without-shlib-symlink for GCC runtime
       libraries.  Thanks to Matthias Klose for the bug report.
       (Closes: #790739)
   * checks/systemd.desc:
     + [AB] Apply patch by Chris Lamb to update link to Debian systemd
       packaging reference. (Closes: #799082)
   * checks/watch-file.desc:
     + [JW] Fix typo.
 .
   * data/binaries/embedded-libs:
     + [RG] Use a different string to detect the copies of freetype
       (Closes: #756722)
     + [RG] Allow ffmpeg to provide libav*.
   * data/debhelper/dh_{commands,packages}:
     + [AB] Apply patch by Stefano Rivera to update the home of
       dh_gstscancodecs. (Closes: #799467)
   * data/obsolete-sites/obsolete-sites:
     + [AB] Add patch by Hideki Yamane to add sourceforge.jp (Closes:
       #798736)
     + [AB] Sort file alphabetically.
   * data/spelling/corrections:
     + [JW] Add more corrections.
 .
   * doc/lintian.xml:
     + [JW] Fix typo.
 .
   * lib/Lintian/Collect.pm:
     + [JW] Fix typo.
   * lib/Lintian/Lab.pm:
     + [JW] Fix typo.
 .
   * man/lintian.pod.in:
     + [JW] Fix typo.
 .
   * private/refresh-debhelper-data:
     + [NT] Add a "This file is generated" header to all output files.
Checksums-Sha1:
 22702a062addb00d4bc7155703b197258b24079a 2758 lintian_2.5.38.dsc
 306f2e4f6e28dd5bec339d9780685474d5fd85a0 1248000 lintian_2.5.38.tar.xz
 acc53666a2def2f3db909bdf106a0ec493cff369 834836 lintian_2.5.38_all.deb
Checksums-Sha256:
 87df794c02437e8bada101116ee9634e446cac353ba8d416880402c4a1b8f0c4 2758 lintian_2.5.38.dsc
 824aea9a80001f9a1747a87ce7e63d7bcd9856ee83671070b0cf14449a963bd8 1248000 lintian_2.5.38.tar.xz
 25109672e988da8471b53d17d7695637191db0f40cee103bef1efeba0181543c 834836 lintian_2.5.38_all.deb
Files:
 05142b32988d85d941706fc03ebbf7bb 2758 devel optional lintian_2.5.38.dsc
 cf55059aaede55db17006ddc5944000e 1248000 devel optional lintian_2.5.38.tar.xz
 91989723fca7804d6c49d7d0cd68d685 834836 devel optional lintian_2.5.38_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWEtqDAAoJEAVLu599gGRCT3kP/3oMj+jq8DQ7Oby5570geTrE
BkJ4FMwNXtYZXsG669a0SOzDQ6ZV96FMysgDzJf/W5vs/G+ytRPfDaeUJpVmXEd8
Co5/MQoy0b1K5jP8fhtpyGsOZAJadOzqRkwnZkzODccUWO5HPAZ0ykG1CYD/23mO
TV2cSEZRaR8ewT8R25xZouLX+djx3HIfHxn8S7P6AUFxUbvqtFT+lnwa2LeNLl43
VZzGN2uG51JVNWht/AgfejhqJjGFdoMcVm39Juj212XpmZYF06PS92lyC61RWRNV
fYu8kjaGPjujfqtx3q+dxQKjMrgqczzLiRULVFcgMYJyONPy9+8ULm5VUg//Clc1
Fe8eGLbAXuHU9jMYRVa/9ytTeqIVtkgIlGPx2gNhtj+31TPN3QWBU5p9gz4flj1n
e7e0QSBPf1qGhheGw9+2bS9WNTeKIXAWDJ1jL2rgp4q7C1qv9EtHFYrqAeMtdSPM
F4D7Tkhuv7EcgZ2N5E3CsZNzC7JS1b4ZY5X+uzLrs4LtH7pdn8is2r1b1BU8JGRl
eIMtmW3nfu1g4ep3tDpJrjULXY+q5fAvySI73zMA24gQJ3iqyuUZFUJS6v8NEObe
QdhhHv7id91UAE8anDILv83Up5/GJwMQiIaaSvYY5nbd6MZQZo+stinkmSbFVZvZ
TZHayI9XjQcGkY28xrTs
=1djX
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: