[lintian] 01/01: L::Check: Fix an uninitialized value warning
This is an automated email from the git hooks/post-receive script.
jwilk pushed a commit to branch master
in repository lintian.
commit 2717a7dc0c8b9c5cd07e90de29edcec6cc4faf67
Author: Jakub Wilk <jwilk@debian.org>
Date: Tue Jan 12 11:12:03 2016 +0100
L::Check: Fix an uninitialized value warning
---
debian/changelog | 2 ++
lib/Lintian/Check.pm | 2 +-
t/tests/fields-maintainer-general/debian/debian/control.in | 2 +-
t/tests/fields-maintainer-general/tags | 4 ++--
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 75f5bcc..4bc3d46 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -34,6 +34,8 @@ lintian (2.5.40) UNRELEASED; urgency=medium
* lib/Lintian/Check.pm:
+ [JW] Remove work-around for Email::Valid bug (#663663), which is now
fixed even in oldstable.
+ + [JW] Apply patch from Justin B Rye to fix an uninitialized value
+ warning. (Closes: #810649)
-- Niels Thykier <niels@thykier.net> Sun, 27 Dec 2015 09:43:24 +0000
diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
index 618430b..4f4b6c6 100644
--- a/lib/Lintian/Check.pm
+++ b/lib/Lintian/Check.pm
@@ -144,7 +144,7 @@ sub check_maintainer {
if (not $mail and $name =~ m/@/) {
# Name probably missing and address has no <>.
$mail = $name;
- $name = undef;
+ $name = '';
}
# Some basic tests.
diff --git a/t/tests/fields-maintainer-general/debian/debian/control.in b/t/tests/fields-maintainer-general/debian/debian/control.in
index 2529636..99750db 100644
--- a/t/tests/fields-maintainer-general/debian/debian/control.in
+++ b/t/tests/fields-maintainer-general/debian/debian/control.in
@@ -1,7 +1,7 @@
Source: {$source}
Priority: extra
Section: {$section}
-Maintainer: <lintian-maint@debian.org>
+Maintainer: lintian-maint@debian.org
Uploaders: <lintian-maint@debian.org>, Russ Allbery <rra@debian.org>,
Russ Allbery <rra@debian.org>,
I L. Oop <fields-maintainer-general@packages.qa.debian.org>,
diff --git a/t/tests/fields-maintainer-general/tags b/t/tests/fields-maintainer-general/tags
index 1fa5999..9ca62a1 100644
--- a/t/tests/fields-maintainer-general/tags
+++ b/t/tests/fields-maintainer-general/tags
@@ -1,9 +1,9 @@
-E: fields-maintainer-general source: maintainer-name-missing <lintian-maint@debian.org>
+E: fields-maintainer-general source: maintainer-name-missing lintian-maint@debian.org
E: fields-maintainer-general source: uploader-address-causes-mail-loops-or-bounces I L. Oop <fields-maintainer-general@packages.qa.debian.org>
E: fields-maintainer-general source: uploader-address-malformed Mr. Missing Comma <mrmc@comma.com> Mrs. Missing Comma <mrsmc@comma.com>
E: fields-maintainer-general source: uploader-name-missing <lintian-maint@debian.org>
E: fields-maintainer-general source: uploader-name-missing you have used a double comma
-E: fields-maintainer-general: maintainer-name-missing <lintian-maint@debian.org>
+E: fields-maintainer-general: maintainer-name-missing lintian-maint@debian.org
W: fields-maintainer-general source: changelog-should-mention-nmu
W: fields-maintainer-general source: duplicate-uploader Russ Allbery <rra@debian.org>
W: fields-maintainer-general source: maintainer-also-in-uploaders
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: