[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/02: c/fields: only emit no-homepage-field for source pkgs



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 32fea5c21961e03ace0a810a6b168e446c61a247
Author: Niels Thykier <niels@thykier.net>
Date:   Tue Feb 2 21:44:08 2016 +0000

    c/fields: only emit no-homepage-field for source pkgs
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/fields.pm                   | 4 ++--
 debian/changelog                   | 2 ++
 t/tests/fields-no-homepage/tags    | 2 +-
 t/tests/lintian-display-level/tags | 2 +-
 t/tests/lintian-output-colons/tags | 2 +-
 t/tests/lintian-output-letter/tags | 2 +-
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/checks/fields.pm b/checks/fields.pm
index ab02e77..c6849b3 100644
--- a/checks/fields.pm
+++ b/checks/fields.pm
@@ -626,9 +626,9 @@ sub run {
             }
             if ($binary_has_homepage_field) {
                 tag 'homepage-in-binary-package';
+            } else {
+                tag 'no-homepage-field';
             }
-        } elsif ($type eq 'binary') {
-            tag 'no-homepage-field';
         }
     }
 
diff --git a/debian/changelog b/debian/changelog
index 85ad004..0e97292 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -9,6 +9,8 @@ lintian (2.5.41) UNRELEASED; urgency=medium
       (Closes: #798900).
     + [BR] Detect pandoc docs avoiding source-is-missing warning.
     + [BR] Fix other source-is-missing FP. (Closes: #813013).
+  * checks/fields.pm:
+    + [NT] Emit "no-homepage-field" only for source packages.
   * checks/files.pm:
     + [JW] Treat packages without Multi-Arch field as if they had
       "Multi-Arch: no".  Thanks to Bas Couwenberg for the bug report.
diff --git a/t/tests/fields-no-homepage/tags b/t/tests/fields-no-homepage/tags
index 221249d..8b3a450 100644
--- a/t/tests/fields-no-homepage/tags
+++ b/t/tests/fields-no-homepage/tags
@@ -1,2 +1,2 @@
 P: fields-no-homepage source: debian-watch-may-check-gpg-signature
-P: fields-no-homepage: no-homepage-field
+P: fields-no-homepage source: no-homepage-field
diff --git a/t/tests/lintian-display-level/tags b/t/tests/lintian-display-level/tags
index 33762b4..abef7c9 100644
--- a/t/tests/lintian-display-level/tags
+++ b/t/tests/lintian-display-level/tags
@@ -9,8 +9,8 @@ I: lintian-display-level: package-contains-empty-directory usr/local/share/linti
 P: lintian-display-level source: debian-control-has-unusual-field-spacing line 11
 P: lintian-display-level source: debian-watch-may-check-gpg-signature
 P: lintian-display-level source: direct-changes-in-diff-but-no-patch-system Changes
+P: lintian-display-level source: no-homepage-field
 P: lintian-display-level: example-unusual-interpreter usr/share/doc/lintian-display-level/examples/example #!/usr/bin/foo
-P: lintian-display-level: no-homepage-field
 W: lintian-display-level source: dfsg-version-misspelled 1.0+dsfg-1.1
 W: lintian-display-level source: maintainer-upload-has-incorrect-version-number 1.0+dsfg-1.1
 W: lintian-display-level: binary-without-manpage usr/bin/script
diff --git a/t/tests/lintian-output-colons/tags b/t/tests/lintian-output-colons/tags
index a7ec8e7..748a191 100644
--- a/t/tests/lintian-output-colons/tags
+++ b/t/tests/lintian-output-colons/tags
@@ -12,7 +12,7 @@ tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:debian-
 tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:debian-watch-may-check-gpg-signature::
 tag:P:pedantic:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:direct-changes-in-diff-but-no-patch-system:Changes:
 tag:P:pedantic:possible::lintian-output-colons:1.0+dsfg-1.1:all:binary:example-unusual-interpreter:usr/share/doc/lintian-output-colons/examples/example #!/usr/bin/foo:
-tag:P:pedantic:possible::lintian-output-colons:1.0+dsfg-1.1:all:binary:no-homepage-field::
+tag:P:pedantic:possible::lintian-output-colons:1.0+dsfg-1.1:source:source:no-homepage-field::
 tag:P:pedantic:wild-guess:O:lintian-output-colons:1.0+dsfg-1.1:all:binary:no-upstream-changelog::no-upstream-changelog
 tag:W:minor:certain:O:lintian-output-colons:1.0+dsfg-1.1:source:source:dfsg-version-misspelled:1.0+dsfg-1.1:dfsg-version-misspelled 1.0*
 tag:W:normal:certain::lintian-output-colons:1.0+dsfg-1.1:source:source:maintainer-upload-has-incorrect-version-number:1.0+dsfg-1.1:
diff --git a/t/tests/lintian-output-letter/tags b/t/tests/lintian-output-letter/tags
index ec02551..034e30f 100644
--- a/t/tests/lintian-output-letter/tags
+++ b/t/tests/lintian-output-letter/tags
@@ -10,8 +10,8 @@ I[W!]: lintian-output-letter source: binary-control-field-duplicates-source fiel
 I[W?]: lintian-output-letter: description-possibly-contains-homepage http://www.example.com/.
 O[M!]: lintian-output-letter source: dfsg-version-misspelled 1.0+dsfg-1.1
 O[P?]: lintian-output-letter: no-upstream-changelog
+P[P ]: lintian-output-letter source: no-homepage-field
 P[P ]: lintian-output-letter: example-unusual-interpreter usr/share/doc/lintian-output-letter/examples/example #!/usr/bin/foo
-P[P ]: lintian-output-letter: no-homepage-field
 P[P!]: lintian-output-letter source: debian-control-has-unusual-field-spacing line 11
 P[P!]: lintian-output-letter source: debian-watch-may-check-gpg-signature
 P[P!]: lintian-output-letter source: direct-changes-in-diff-but-no-patch-system Changes

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: