Bug#809440: lintian: runtime-test-file-is-not-a-regular-file complains about a symlink to a regular test file

[Jakub Wilk <jwilk@debian.org>]

Hi Christian, hi Raphaël!

* Christian Seiler <christian@iwakd.de>, 2016-02-14, 04:29:
> > With python-django 1.9-2 I get those tags:
> > I: python-django source: runtime-test-file-is-not-a-regular-file debian/tests/django-admin-py3
> > I: python-django source: runtime-test-file-is-not-a-regular-file debian/tests/test-suite-py3
> >
> > Both files are symlinks to another script (which is a regular file) in 
> > the same directory. autopkgtest works perfectly well with such test 
> > files... thus you should not trigger the tag in this case.

I suspect this is a relic from the times before we had an API to check 
if a file is safe to open (is_open_ok).

> Relative symbolic links to autopkgtest tests should be allowed as long 
> as they point to regular files. This adds the following tags for 
> identifying problematic types of symlinks:
>
> - runtime-test-file-is-absolute-symlink
> - runtime-test-file-is-self-recursive-symlink
> - runtime-test-file-is-broken-symlink
> - runtime-test-file-is-symlink-to-non-regular-file

I don't think we need separate tags for every kind of brokenness.
One tag should be enough.

--
Jakub Wilk