[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: c/changelog-file: Use "day of week" instead of "weekday"



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit 6be53a1cd87ac955a43e3e6929822dea173c7a5a
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Apr 9 21:55:25 2016 +0000

    c/changelog-file: Use "day of week" instead of "weekday"
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/changelog-file.desc                | 4 ++--
 checks/changelog-file.pm                  | 2 +-
 debian/changelog                          | 3 +++
 t/tests/changelog-file-wrong-weekday/desc | 2 +-
 t/tests/changelog-file-wrong-weekday/tags | 2 +-
 t/tests/legacy-foo++/tags                 | 2 +-
 6 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index ceeba26..a9ab933 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -389,11 +389,11 @@ Info: The Debian portion of the package version contains a reference to a
  package doesn't change before the next release cycle starts.
 Ref: devref 5.13.3
 
-Tag: debian-changelog-has-wrong-weekday
+Tag: debian-changelog-has-wrong-day-of-week
 Severity: normal
 Certainty: certain
 Info: The date in the changelog entry is not consistent with the actual
- weekday.  Either the date is wrong or the weekday is wrong.
+ day of that week.  Either the date is wrong or the day of week is wrong.
  .
  To avoid problems like this, consider using a tool like dch(1) or
  date(1) to generate the date.  Example:
diff --git a/checks/changelog-file.pm b/checks/changelog-file.pm
index f0b384d..a8e1deb 100644
--- a/checks/changelog-file.pm
+++ b/checks/changelog-file.pm
@@ -291,7 +291,7 @@ sub run {
             if ($tz and $weekday_declared ne $weekday_actual) {
                 my $real_weekday = time2str('%A', $first_timestamp, $tz);
                 my $short_date = time2str('%Y-%m-%d', $first_timestamp, $tz);
-                tag 'debian-changelog-has-wrong-weekday',
+                tag 'debian-changelog-has-wrong-day-of-week',
                   "$short_date is a $real_weekday";
             }
         }
diff --git a/debian/changelog b/debian/changelog
index caf422b..826a8cf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,9 @@ lintian (2.5.44) UNRELEASED; urgency=medium
 
   XXX: generate tag summary with private/generate-tag-summary
 
+  * checks/changelog-file.{desc,pm}:
+    + [JW,NT] Use "day of week" rather than "weekday".
+      (Closes: #796093)
   * checks/description.{desc,pm}:
     + [NT] Drop duplicate word tag, which is now covered by the
       spelling error check.
diff --git a/t/tests/changelog-file-wrong-weekday/desc b/t/tests/changelog-file-wrong-weekday/desc
index 780319b..5813979 100644
--- a/t/tests/changelog-file-wrong-weekday/desc
+++ b/t/tests/changelog-file-wrong-weekday/desc
@@ -3,4 +3,4 @@ Sequence: 6000
 Version: 1.0
 Profile: lintian-test
 Description: Test for wrong weekday in changelog date
-Test-For: debian-changelog-has-wrong-weekday
+Test-For: debian-changelog-has-wrong-day-of-week
diff --git a/t/tests/changelog-file-wrong-weekday/tags b/t/tests/changelog-file-wrong-weekday/tags
index b422b4a..7755e4a 100644
--- a/t/tests/changelog-file-wrong-weekday/tags
+++ b/t/tests/changelog-file-wrong-weekday/tags
@@ -1 +1 @@
-W: changelog-file-wrong-weekday: debian-changelog-has-wrong-weekday 2016-04-07 is a Thursday
+W: changelog-file-wrong-weekday: debian-changelog-has-wrong-day-of-week 2016-04-07 is a Thursday
diff --git a/t/tests/legacy-foo++/tags b/t/tests/legacy-foo++/tags
index 8fd358c..a493e6d 100644
--- a/t/tests/legacy-foo++/tags
+++ b/t/tests/legacy-foo++/tags
@@ -21,6 +21,6 @@ W: foo++ source: debian-watch-file-unknown-version 0
 W: foo++ source: dm-upload-allowed-is-obsolete
 W: foo++ source: uploader-address-looks-weird Jeroen van Wolffelaar<jeroen@localhost.localdomain>
 W: foo++-helper: empty-binary-package
-W: foo++: debian-changelog-has-wrong-weekday 2003-04-14 is a Monday
+W: foo++: debian-changelog-has-wrong-day-of-week 2003-04-14 is a Monday
 W: foo++: latest-debian-changelog-entry-without-new-date
 W: foo++: readme-debian-contains-invalid-email-address foo@unknown

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: