[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#840009: [PATCH] lintian : privacy-breach-generic support for <audio>



Package: lintian
Version: 2.5.48
Tags: patch

--

Dear maintainer,

it seems lintian does not currently detect privacy breaches within <audio> element
; Jerome Benoit noticed that in #838870.
Could you confirm and review the attached patch ?
Thank you,

F.
diff -Nru lintian-2.5.48/data/files/privacy-breaker-tag-attr lintian-2.5.48/data/files/privacy-breaker-tag-attr
--- lintian-2.5.48/data/files/privacy-breaker-tag-attr	2016-09-25 18:21:57.000000000 +0000
+++ lintian-2.5.48/data/files/privacy-breaker-tag-attr	2016-10-04 19:37:17.000000000 +0000
@@ -19,3 +19,4 @@
 track            ~~ src="http       && <track     || src="ftp       && <track   || src="//       && <track  ~~ (<(track) (?:\s[^>]+)? \s+ src="(&URL)" [^>]*>)
 video src=       ~~ src="http       && <video     || src="ftp       && <video   || src="//       && <video  ~~ (<(video) (?:\s[^>]+)? \s+ src="(&URL)" [^>]*>)
 video poster=    ~~ poster="http    && <video     || poster="ftp    && <video   || poster="//    && <video  ~~ (<(video) (?:\s[^>]+)? \s+ poster="(&URL)" [^>]*>)
+audio            ~~ src="http       && <audio     || src="ftp       && <audio   || src="//       && <audio  ~~ (<(audio) (?:\s[^>]+)? \s+ src="(&URL)" [^>]*>)
diff -Nru lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audio.html lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audio.html
--- lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audio.html	1970-01-01 00:00:00.000000000 +0000
+++ lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audio.html	2016-10-04 19:37:17.000000000 +0000
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<html>
+<body>
+<audio src="ftp://1984.os/tuxistrackingme.ogg"; />
+</audio>
+</body>
+</html>
diff -Nru lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audiotrack.html lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audiotrack.html
--- lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audiotrack.html	1970-01-01 00:00:00.000000000 +0000
+++ lintian-2.5.48/t/tests/files-privacybreach/debian/src/privacy-breach-generic/audiotrack.html	2016-10-04 19:37:17.000000000 +0000
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<body>
+<audio controls>
+  <source src="tux.mp3" type="audio/mpeg">
+  <source src="tux.ogg" type="audio/ogg">
+  <track src="en.vtt" kind="captions" srclang="en" label="English">
+  <track src="http://1984.os/notracking.vtt"; kind="captions" srclang="no" label="Norwegian">
+</audio>
+</body>
+</html>
diff -Nru lintian-2.5.48/t/tests/files-privacybreach/tags lintian-2.5.48/t/tests/files-privacybreach/tags
--- lintian-2.5.48/t/tests/files-privacybreach/tags	2016-09-25 18:22:03.000000000 +0000
+++ lintian-2.5.48/t/tests/files-privacybreach/tags	2016-10-04 19:37:17.000000000 +0000
@@ -53,6 +53,8 @@
 E: files-privacybreach: privacy-breach-w3c-valid-html usr/share/files-privacy-breach/privacy-breach-w3c-valid-html/htmlvalid.html (http://www.w3.org/icons/valid-xhtml10)
 X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/applet.html (//1984.os/trackme2)
 X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/applet.html (http://1984.os/trackme)
+X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/audio.html (ftp://1984.os/tuxistrackingme.ogg)
+X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/audiotrack.html (http://1984.os/notracking.vtt)
 X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/div.html (//trackme.1984/index-3.html)
 X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/div.html (http://trackme.1984/index-2.html)
 X: files-privacybreach: privacy-breach-generic usr/share/files-privacy-breach/privacy-breach-generic/embed.html (//1984.os/givemydata2.swf)

Reply to: