[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 02/02: c/src-cpy: Simplify code



This is an automated email from the git hooks/post-receive script.

nthykier pushed a commit to branch master
in repository lintian.

commit fde8505b2b632623fd10cbe42c496ae6c935246b
Author: Niels Thykier <niels@thykier.net>
Date:   Sat Oct 22 10:14:25 2016 +0000

    c/src-cpy: Simplify code
    
    Signed-off-by: Niels Thykier <niels@thykier.net>
---
 checks/source-copyright.pm | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/checks/source-copyright.pm b/checks/source-copyright.pm
index 0d7dde3..b8bf311 100644
--- a/checks/source-copyright.pm
+++ b/checks/source-copyright.pm
@@ -352,16 +352,14 @@ sub _parse_dep5 {
                                 # Special-case => Files: *
                                 push(@wlist, get_all_files($info));
                             } else {
-                                push(@wlist, $dir->children);
+                                push(@wlist,
+                                    grep { $_->is_file }
+                                      $dir->children('breadth-first'));
                             }
+                            $used = 1 if @wlist;
                         }
-                        while (my $entry = pop(@wlist)) {
-                            if ($entry->is_file) {
-                                $used = 1;
-                                $file_coverage{$entry->name} = $current_line;
-                            } elsif ($entry->is_dir) {
-                                push(@wlist, $entry->children);
-                            }
+                        for my $entry (@wlist) {
+                            $file_coverage{$entry->name} = $current_line;
                         }
                     } else {
                         for my $srcfile (%file_coverage) {

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: