[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#899134: marked as done (lintian: desktop file checks have outdated links)



Your message dated Sat, 19 May 2018 20:40:56 +0000
with message-id <E1fK8eu-000Af6-DP@fasolo.debian.org>
and subject line Bug#899134: fixed in lintian 2.5.87
has caused the Debian Bug report #899134,
regarding lintian: desktop file checks have outdated links
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
899134: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=899134
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.86
Severity: normal
Tags: patch

The desktop file checks contain links to the spec.  Some of these need to be
updated for the latest version of the spec.  The attached patch fixes the
issues I found this morning.

Ross
>From d0c2fc81c847bb3015768c33820c3d21f9418aa9 Mon Sep 17 00:00:00 2001
From: Ross Vandegrift <ross@kallisti.us>
Date: Sat, 19 May 2018 10:01:04 -0700
Subject: [PATCH] Update freedesktop.org desktop spec links

Section page links have changed in the latest version of the desktop spec.
Also, s/standards/specifications/ to match the rest of lintian.
---
 checks/menu-format.desc             | 16 ++++++++--------
 checks/menu-format.pm               |  2 +-
 data/menu-format/known-desktop-keys |  2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/checks/menu-format.desc b/checks/menu-format.desc
index b9027bf..9ae97ce 100644
--- a/checks/menu-format.desc
+++ b/checks/menu-format.desc
@@ -252,7 +252,7 @@ Info: The desktop entry file has lines ending in CRLF instead of just LF.
  <tt>CR</tt> character in the file:
  .
  <tt>sed -i 's/\r//g' path/to/file</tt>
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s02.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s03.html
 
 Tag: duplicated-key-in-desktop-entry
 Severity: normal
@@ -270,7 +270,7 @@ Info: Desktop entries must contain, at a minimum, the keys Type and Name.
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
 
 Tag: desktop-entry-contains-unknown-key
 Severity: minor
@@ -282,7 +282,7 @@ Info: The key on this line of the desktop entry is not one of the standard
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
 
 Tag: desktop-entry-contains-deprecated-key
 Severity: normal
@@ -292,7 +292,7 @@ Info: The key on this line of the desktop entry has been deprecated in the
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
 
 Tag: desktop-entry-contains-encoding-key
 Severity: wishlist
@@ -304,7 +304,7 @@ Info: The Encoding key is now deprecated by the FreeDesktop standard and
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
 
 Tag: desktop-entry-lacks-main-category
 Severity: normal
@@ -329,7 +329,7 @@ Info: This .desktop file does not contain an "Icon" entry.
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
  https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html,
  #854132
 
@@ -346,7 +346,7 @@ Info: This .desktop file does either not contain a "Keywords" entry or it does
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html,
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
  #693918, https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords
 
 Tag: desktop-entry-uses-reserved-category
@@ -393,7 +393,7 @@ Info: The key on this line of the desktop entry has been deprecated in the
  .
  The desktop-file-validate tool in the desktop-file-utils package is
  useful for checking the syntax of desktop entries.
-Ref: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html
+Ref: https://specifications.freedesktop.org/desktop-entry-spec/latest/apc.html
 
 Tag: desktop-mime-but-no-exec-code
 Severity: normal
diff --git a/checks/menu-format.pm b/checks/menu-format.pm
index 295079f..0edf43e 100644
--- a/checks/menu-format.pm
+++ b/checks/menu-format.pm
@@ -96,7 +96,7 @@ my $DEPRECATED_DESKTOP_KEYS
 my $KDE_DESKTOP_KEYS = Lintian::Data->new('menu-format/kde-desktop-keys');
 
 # Known types of desktop entries.
-# https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+# https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
 my %known_desktop_types = map { $_ => 1 } qw(
   Application
   Link
diff --git a/data/menu-format/known-desktop-keys b/data/menu-format/known-desktop-keys
index 568cfba..01a520c 100644
--- a/data/menu-format/known-desktop-keys
+++ b/data/menu-format/known-desktop-keys
@@ -1,4 +1,4 @@
-# from https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
+# from https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
 # list of Recognized desktop entry keys
 # please alpha sort
 #
-- 
2.17.0


--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.87

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 899134@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 19 May 2018 19:30:19 +0000
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.87
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 lintian    - Debian package checker
Closes: 897608 898377 898592 898708 898715 898799 899134
Changes:
 lintian (2.5.87) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - debian-pyversions-is-obsolete
       - debug-symbol-migration-possibly-complete
       - header-has-overly-generic-name
 .
   * checks/cruft.{desc,pm}:
     + [CL] Apply patch from Joseph Herlant to warn about use of obsolete
       debian/pyversion files.  Thanks!  (Closes: #898592)
   * checks/debhelper.pm:
     + [CL] Prevent false-positives with comments and newlines when checking
       debhelper-compat-file-contains-multiple-levels.  (Closes: #898799)
   * checks/fields.{desc,pm}:
     + [BR] Detect privacy breaches in Internet Explorer "<!--[if IE 8]>"
       conditional comments.
     + [CL] Rename python-generic-modules data file to
       generic-python-modules.
     + [CL] Warn about packages that install files under /usr/include with
       overly-generic filenames.  Thanks to Andreas Beckmann for the report.
       (Closes: #898377)
     + [CL] Apply patch from Ian Jackson to not detect
       https://browse.dgit.debian.org/example.git as a VCS deprecated in the
       Debian infrastucture.  (Closes: #898708)
   * checks/files.pm:
     + [BR] Add "umd" as a possible suffix for minified Javascript.
       (alongside "lite", "min", "pack", etc.)
   * checks/menu-format.{desc,pm}:
     + [CL] Apply patch from Ross Vandegrift to update specification URIs.
       (Closes: #899134)
   * checks/upstream-metadata.desc:
     + [CL] Correct a "non-file directory entry" grammatical error in the
       description of the upstream-metadata-is-not-a-file tag.
 .
   * data/files/js-libraries:
     + [BR] Detect uses of the libjs-normalize.css CSS "style reset" helper.
   * data/files/privacy-breaker-websites:
     + [BR] Detect uses of the "libjs-rx" API for asynchronous programming.
   * data/rules/rules-should-not-use:
     + [CL] Add a pedantic-level warning about possibly complete automatic
       debug symbol migrations.  Thanks to Graham Inggs for the report.
       (Closes: #897608)
   * data/spelling/corrections:
     + [PW] Add a number of corrections.
 .
   * lib/Lintian/Collect/Package.pm:
     + [CL] Support parsing tar(1) archives with high-resolution timestamps
       (eg. "21:47:29.12396808").  Based on a patch by Stephen Kitt; thanks!
       (Closes: #898715)
Checksums-Sha1:
 98c95f0fb7a5629ebb564b7cc0d6c40c6bc60534 3511 lintian_2.5.87.dsc
 1279f179feb1677ae94ba5d0163482b3e3bdb088 1561148 lintian_2.5.87.tar.xz
 f18688ae6ddb658179853f50a208f4ffbadfc614 1121564 lintian_2.5.87_all.deb
 ecfc13885365e4278e59ac1d7fbdd9475796994b 16047 lintian_2.5.87_amd64.buildinfo
Checksums-Sha256:
 952cfe96edd84b88cbbedda70b5bdb8cf984aa05126727d26c7feb94c7bb4889 3511 lintian_2.5.87.dsc
 e4ebfd63d87eed1b655d3e6f4668142a42aefa02cbfdd19248483a892db29515 1561148 lintian_2.5.87.tar.xz
 e79c6b502d1eed223cbcbd7d6bf5b324f9473f0f98c4b98d0b7bcccf2804667a 1121564 lintian_2.5.87_all.deb
 7f7899f1f89402cd92ea13a1cc3ec40114f70f8e1c66d0a7b5b9ef63c5a1d0bb 16047 lintian_2.5.87_amd64.buildinfo
Files:
 95b99d1beced11587e8a6e08fa073c64 3511 devel optional lintian_2.5.87.dsc
 90256f02ee09e87f9d67c2b3ea2f1b39 1561148 devel optional lintian_2.5.87.tar.xz
 4d75e4128613f8d6182e463299b89c73 1121564 devel optional lintian_2.5.87_all.deb
 d5bbc7789413a064f6f5ba42fe9f2666 16047 devel optional lintian_2.5.87_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlsAhkMACgkQHpU+J9Qx
HliKqg//aduzGkFdGLBJEHz92IBTBXoAfT9sIq75SulxnZZdzfKKVhv5sVLsKDxg
MafOe5rbMeudo4K1fq6i1yuiI6G4ANDlTxm6cHluoBO4WtuaM0DuHh3RW4NLwPXn
8SZLUxQq+5FkviAwfnY1Sjar6V2KpXd77iST3gau1Li9ItC+JBiB0WAdUDMOB1NB
S/HcTe0GJ3IAfPhAP4fb2agolRaVTXiqqg3N5tSDPZ/0Jw/KxwyMdsIdeVqQeAOJ
N2FGLpHpYiXC8q5xQGUHL/df1AjGAU34piNk8pY18Fgyv3eHjiDQ3K1qgw0HoTx2
l9W31keKzI6lvfTgFOdtw1WjHTbfWKPhaxRRBmoD7vZzhDhsYTm+elx4gnjkPmue
TrPSuc/3mLT/fcuTIS04xkTWPycdzoZcS+BZ7y6+DyPJpuMpGEq9Xp+sWepyhuHp
vNrBi8VSnJTm4VOP2uuivxWnanJHRtQD3Tba8m9YU2Q1BSWuwvzNl0ZglmGXuL0k
ePX9TLo+TAng+c/9q8C6D4oHeiRXA19y3guP8RvpsSFjK6z1AK6FqeJ0lryiC8kb
p7BazqKLbpFB9/8faTOs6KyqRNv9k1M4IkfJXb43Sj2YbKey5cp2er9iZToCLNJY
67nXiCjBR5VF48L+8XFS7H7UGwyHC95z2v32IDq1cPnb4qCIQYc=
=yQso
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: