[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#944047: lintian: warn against Build-Depends-Package: #PACKAGE# in symbol files



Hi Felix

On 2019-11-03 05:49:59, Felix Lechner wrote:
> On Sun, Nov 3, 2019 at 2:24 AM Sebastian Ramacher <sramacher@debian.org> wrote:
> >
> > In libdvdread 6.0.1-1, the following line was added to "fix" the
> > lintian info on the missing Build-Depends-Package:
> >
> > | * Build-Depends-Package: #PACKAGE#
> >
> > This causes the package name of the shared library to be substituted,
> > and not the -dev package. So please warn against Build-Depends-Package
> > lines of this form.
> 
> That's funny. I often thought about doing the same. It seems some
> program in the middle should be smart enough to fill it in.

Nobody wrote that program yet.

> Isn't that
> what happens to #MINVAR?

#MINVER# is not replaced at build time. Installed symbol files still
contain #MINVER#, wheras #PACKAGE# gets replaced during package build.

As for your new Lintian tag, we like to start
> them on the lower end of their severity. Would 'I' (informational) be
> okay for now?
> 
> Also, do you have any suggestions on how to fix the tag description
> for symbols-file-missing-build-depends-package-field? We should
> perhaps clarify that #PACKAGE# is not the right value to use.

No, I don't. But I am also not a fan of that tag.

> I looked briefly at the relevant portions of dpkg-shlibdeps (1),
> policy [2], deb-symbols (5) and the Debian Maintainer's Guide [3]
> (dpkg-gensymbols does not mention the field) but I could not find
> much. Is there a variable that would work?

No, not as far as I am aware.

Cheers

> 
> Kind regards,
> Felix Lechner
> 
> [1] https://lintian.debian.org/tags/symbols-file-missing-build-depends-package-field.html
> [2] http://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-symbols
> [3] https://www.debian.org/doc/manuals/maint-guide/advanced.en.html#librarysymbols

-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


Reply to: