Bug#1002822: python3-gitlab: Should likely not ship /usr/lib/python3/dist-packages/docs/conf.py ("trying to overwrite '/usr/lib/python3/dist-packages/docs/conf.py', which is also in package python3-diskcache 5.2.1-2")
Package: python3-gitlab
Version: 1:2.10.0-1
Severity: serious
Control: clone -1 -2
Control: clone -1 -3
Control: reassign -2 python3-diskcache 5.2.1-2
Control: retitle -2 python3-diskcache: Should likely not ship /usr/lib/python3/dist-packages/docs/conf.py ("trying to overwrite '/usr/lib/python3/dist-packages/docs/conf.py', which is also in package python3-gitlab 1:2.10.0-1")
Control: severity -3 wishlist
Control: reassign -3 lintian
Control: retitle -3 lintian: Should warn about packages installing _any_ file directly under /usr/lib/python3/dist-packages/docs/ and similar locations
python3-gitlab 1:2.10.0-1 as well as python3-diskcache 5.2.1-2 both ship
/usr/lib/python3/dist-packages/docs/conf.py which is a serious bug
alone:
Unpacking python3-gitlab (1:2.10.1-1) over (1:2.10.0-1) ...
dpkg: error processing archive /var/cache/apt/archives/python3-gitlab_1%3a2.10.1-1_all.deb (--unpack):
trying to overwrite '/usr/lib/python3/dist-packages/docs/conf.py', which is also in package python3-diskcache 5.2.1-2
Errors were encountered while processing:
/var/cache/apt/archives/python3-gitlab_1%3a2.10.1-1_all.deb
For python3-diskcache, it should very likely not install these files at
all:
/usr/lib/python3/dist-packages/docs/Makefile
/usr/lib/python3/dist-packages/docs/api.rst
/usr/lib/python3/dist-packages/docs/cache-benchmarks.rst
/usr/lib/python3/dist-packages/docs/case-study-landing-page-caching.rst
/usr/lib/python3/dist-packages/docs/case-study-web-crawler.rst
/usr/lib/python3/dist-packages/docs/conf.py
/usr/lib/python3/dist-packages/docs/development.rst
/usr/lib/python3/dist-packages/docs/djangocache-benchmarks.rst
/usr/lib/python3/dist-packages/docs/index.rst
/usr/lib/python3/dist-packages/docs/make.bat
/usr/lib/python3/dist-packages/docs/tutorial.rst
And these files are probably edgy:
/usr/lib/python3/dist-packages/docs/sf-python-2017-meetup-talk.rst (clearly belongs to /usr/share/doc/python3-diskcache/)
/usr/lib/python3/dist-packages/docs/_static/core-p1-delete.png
/usr/lib/python3/dist-packages/docs/_static/core-p1-get.png
/usr/lib/python3/dist-packages/docs/_static/core-p1-set.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-delete.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-get.png
/usr/lib/python3/dist-packages/docs/_static/core-p8-set.png
/usr/lib/python3/dist-packages/docs/_static/custom.css
/usr/lib/python3/dist-packages/docs/_static/djangocache-delete.png
/usr/lib/python3/dist-packages/docs/_static/djangocache-get.png
/usr/lib/python3/dist-packages/docs/_static/djangocache-set.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation-03.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation-05.png
/usr/lib/python3/dist-packages/docs/_static/early-recomputation.png
/usr/lib/python3/dist-packages/docs/_static/gj-logo.png
/usr/lib/python3/dist-packages/docs/_static/no-caching.png
/usr/lib/python3/dist-packages/docs/_static/synchronized-locking.png
/usr/lib/python3/dist-packages/docs/_static/traditional-caching.png
/usr/lib/python3/dist-packages/docs/_templates/gumroad.html
For python3-gitlab, it should very likely not install these files at
all:
python3-gitlab: /usr/lib/python3/dist-packages/docs/__init__.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/conf.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/ext/__init__.py
python3-gitlab: /usr/lib/python3/dist-packages/docs/ext/docstrings.py
But I suspect that no package at all should ship a file in such a
generic location. So on the one hand not filing these issues against
"python3-gitlab _OR_ python3-diskcache" but against "python3-gitlab
_AND_ python3-diskcache".
And I'm filing this a wishlist bug against lintian as well.
I'd say any file …
* directly in /usr/lib/python3/dist-packages/docs/ should cause at least
a warning or even an error.
* in a subdirectory of /usr/lib/python3/dist-packages/docs/ which is
starting with an underscore ("_") should probably get a warning or at
least a pedantic warning.
* And maybe for shipping any file in
/usr/lib/python3/dist-packages/docs/ext/ as well.
* And according to #947264, #998820 and #973627 maybe also
/usr/lib/python3/dist-packages/examples/,
/usr/lib/python3/dist-packages/scripts/ and
/usr/lib/python3/dist-packages/benchmarks/.
This likely is an expansion of the what
python-module-has-overly-generic-name already reports.
python-module-has-overly-generic-name is part of the
data/archive/auto-rejection.yaml and since both packages,
python3-diskcache as well as python3-gitlab seem to have no lintian
overrides, the tag seems not to have been triggered by these packages.
Then again, a local lintian run does not confirm this, at least not for
python3-gitlab:
$ lintian python3-gitlab_2.10.1-1_all.deb python3-diskcache_5.2.1-2_all.deb
E: python3-gitlab: python-module-has-overly-generic-name usr/lib/python3/dist-packages/docs/__init__.py (docs)
I: python3-diskcache: […]
So I wonder how python3-gitlab could get into the archive. Or is
data/archive/auto-rejection.yaml not in sync with the list that
ftp-masters actually use for lintian-based rejections? (JFTR: I checked
git HEAD of lintian, i.e. commit b996cbba, not the actual package in
unstable.)
-- System Information:
Debian Release: bookworm/sid
APT prefers unstable
APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.15.0-trunk-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled
Versions of packages python3-gitlab depends on:
ii python3 3.9.8-1
ii python3-requests 2.25.1+dfsg-2
ii python3-requests-toolbelt 0.9.1-1
python3-gitlab recommends no packages.
Versions of packages python3-gitlab suggests:
pn python-gitlab-doc <none>
-- no debconf information
Reply to: