Re: [DEBIAN-LTS] ettercap package
Hi all,
I have done rebuild the ettercap package using quilt patch.
Could you please give me some comments.
Hi all,
I have just finished building package ettercap for squeeze-lts.
I attached debdiff file
(according to
https://wiki.debian.org/LTS/Development?highlight=%28\bCategoryLts\b%29).
Could anyone please help me to review it.
Thanks
--
CongNT
Please forget this email. I have troubled with my mail server.
Sorry for this inconvenience.
Thanks and best regards
Cong
On 24/12/2014 15:01, Raphael Hertzog wrote:
Hello,
On Tue, 23 Dec 2014, Thorsten Alteholz wrote:
On Tue, 23 Dec 2014, Nguyen Cong wrote:
I have created .deb file for ettercap package.
great, thanks alot.
Since I'm not DD or DM so I attached debdiff file for review
as mentioned in LTS/Development wiki page.
Could anyone please check it and tell me if any comments?
After a first glimpse it seems to be that this package uses quilt, but you
directly changed the source files. Please don't change the way of the
original maintainer to handle patches.
It looks like the upstream author made the same mistake when preparing
an upload of his own in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773416#50
I propose to let Nguyen Cong take care of fixing this so that he can
learn about quilt and have some easy entry into contributing to the LTS
team. Nguyen, feel free to get some inspiration from Gianfranco's more
verbose changelog message though. :)
Cheers,
--
=====================================================================
Nguyen The Cong (Mr)
Software Engineer
Toshiba Software Development (Vietnam) Co.,Ltd
519 Kim Ma street, Ba Dinh District, Hanoi, Vietnam
tel: +84-4-2220 8801 (Ext. 208)
e-mail: cong.nguyenthe@toshiba-tsdv.com
=====================================================================
Note: This e-mail message may contain personal information or confidential information. If you are not the addressee of this message, please delete this message and kindly notify the sender as soon as possible - do not copy, use, or disclose this message.
diff -u ettercap-0.7.3/debian/changelog ettercap-0.7.3/debian/changelog
--- ettercap-0.7.3/debian/changelog
+++ ettercap-0.7.3/debian/changelog
@@ -1,3 +1,11 @@
+ettercap (1:0.7.3-2.1+squeeze2) squeeze-lts; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix CVE-2014-9380 and CVE-2014-9381 using patch file from
+ Gianfranco Costamagna in Bug#773416 Mes#20
+
+ -- Nguyen Cong <cong.nguyenthe@toshiba-tsdv.com> Tue, 23 Dec 2014 09:44:32 +0700
+
ettercap (1:0.7.3-2.1+squeeze1) stable; urgency=high
* Quilt patch for CVE-2013-0722, a stack-based buffer overflow when
diff -u ettercap-0.7.3/debian/patches/series ettercap-0.7.3/debian/patches/series
--- ettercap-0.7.3/debian/patches/series
+++ ettercap-0.7.3/debian/patches/series
@@ -3,0 +4 @@
+04_CVE-2014-9380-9381.patch
diff -u ettercap-0.7.3/debian/patches/03_CVE-2013-0722.patch ettercap-0.7.3/debian/patches/03_CVE-2013-0722.patch
--- ettercap-0.7.3/debian/patches/03_CVE-2013-0722.patch
+++ ettercap-0.7.3/debian/patches/03_CVE-2013-0722.patch
@@ -13,8 +13,6 @@
src/ec_scan.c | 2 +-
3 files changed, 21 insertions(+), 18 deletions(-)
-diff --git a/include/ec.h b/include/ec.h
-index 3bc8aa2..e1f4a8a 100644
--- a/include/ec.h
+++ b/include/ec.h
@@ -78,6 +78,11 @@
@@ -29,8 +27,6 @@
#define __init __attribute__ ((constructor))
#ifndef __set_errno
-diff --git a/include/ec_inet.h b/include/ec_inet.h
-index 50fc568..17838e4 100644
--- a/include/ec_inet.h
+++ b/include/ec_inet.h
@@ -23,24 +23,22 @@
@@ -40,14 +36,13 @@
-enum {
- NS_IN6ADDRSZ = 16,
- NS_INT16SZ = 2,
--
++#define NS_IN6ADDRSZ 16
++#define NS_INT16SZ = 2
+
- ETH_ADDR_LEN = 6,
- TR_ADDR_LEN = 6,
- FDDI_ADDR_LEN = 6,
- MEDIA_ADDR_LEN = 6,
-+#define NS_IN6ADDRSZ 16
-+#define NS_INT16SZ = 2
-+
+#define ETH_ADDR_LEN 6
+#define TR_ADDR_LEN 6
+#define FDDI_ADDR_LEN 6
@@ -56,16 +51,15 @@
- IP_ADDR_LEN = 4,
- IP6_ADDR_LEN = 16,
- MAX_IP_ADDR_LEN = IP6_ADDR_LEN,
--
++#define IP_ADDR_LEN 4
++#define IP6_ADDR_LEN 16
++#define MAX_IP_ADDR_LEN IP6_ADDR_LEN
+
- ETH_ASCII_ADDR_LEN = sizeof("ff:ff:ff:ff:ff:ff")+1,
- IP_ASCII_ADDR_LEN = sizeof("255.255.255.255")+1,
- IP6_ASCII_ADDR_LEN = sizeof("ffff:ffff:ffff:ffff:ffff:ffff:255.255.255.255")+1,
- MAX_ASCII_ADDR_LEN = IP6_ASCII_ADDR_LEN,
-};
-+#define IP_ADDR_LEN 4
-+#define IP6_ADDR_LEN 16
-+#define MAX_IP_ADDR_LEN IP6_ADDR_LEN
-+
+#define ETH_ASCII_ADDR_LEN 19 // sizeof("ff:ff:ff:ff:ff:ff")+1
+#define IP_ASCII_ADDR_LEN 17 // sizeof("255.255.255.255")+1
+#define IP6_ASCII_ADDR_LEN 47 // sizeof("ffff:ffff:ffff:ffff:ffff:ffff:255.255.255.255")+1
@@ -73,8 +67,6 @@
/*
* this structure is used by ettercap to handle
-diff --git a/src/ec_scan.c b/src/ec_scan.c
-index 59a8f14..423b323 100644
--- a/src/ec_scan.c
+++ b/src/ec_scan.c
@@ -544,7 +544,7 @@ int scan_load_hosts(char *filename)
only in patch2:
unchanged:
--- ettercap-0.7.3.orig/debian/patches/04_CVE-2014-9380-9381.patch
+++ ettercap-0.7.3/debian/patches/04_CVE-2014-9380-9381.patch
@@ -0,0 +1,30 @@
+From: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
+Subject: Re: Bug#773416: fixed in ettercap 1:0.8.1-3
+Date: Mon, 22 Dec 2014 10:22:56 +0000 (UTC)
+
+The dissector_cvs function in dissectors/ec_cvs.c in Ettercap 8.1
+allows remote attackers to cause a denial of service (out-of-bounds
+read) via a packet containing only a CVS_LOGIN signature.
+
+See Debian Bug #773416 Message #20
+
+--- a/src/dissectors/ec_cvs.c
++++ b/src/dissectors/ec_cvs.c
+@@ -70,7 +70,7 @@ FUNC_DECODER(dissector_cvs)
+ {
+ DECLARE_DISP_PTR_END(ptr, end);
+ char tmp[MAX_ASCII_ADDR_LEN];
+- char *p;
++ u_char *p;
+ size_t i;
+
+ /* don't complain about unused var */
+@@ -92,6 +92,8 @@ FUNC_DECODER(dissector_cvs)
+
+ /* move over the cvsroot path */
+ ptr += strlen(CVS_LOGIN) + 1;
++ if (ptr >= end)
++ return NULL;
+
+ /* go until \n */
+ while(*ptr != '\n' && ptr != end) ptr++;
Format: 1.8
Date: Tue, 23 Dec 2014 09:44:32 +0700
Source: ettercap
Binary: ettercap-common ettercap ettercap-gtk
Architecture: source i386
Version: 1:0.7.3-2.1+squeeze2
Distribution: squeeze-lts
Urgency: medium
Maintainer: Murat Demirten <murat@debian.org>
Changed-By: Nguyen Cong <cong.nguyenthe@toshiba-tsdv.com>
Description:
ettercap - Multipurpose sniffer/interceptor/logger for switched LAN
ettercap-common - Common support files and plugins for ettercap
ettercap-gtk - Multipurpose sniffer/interceptor/logger for switched LAN
Changes:
ettercap (1:0.7.3-2.1+squeeze2) squeeze-lts; urgency=medium
.
* Non-maintainer upload.
* Fix CVE-2014-9380 and CVE-2014-9381 using patch file from
Gianfranco Costamagna in Bug#773416 Mes#20
Checksums-Sha1:
bcc274f8d38612ff7cef88249f5f441063c9d2f6 942 ettercap_0.7.3-2.1+squeeze2.dsc
016721bf83014fdef3378741af0f0a382a66cede 6982 ettercap_0.7.3-2.1+squeeze2.diff.gz
ea26a7fa39e92c82d4baf8ee314b7cbb3df5b62f 304050 ettercap-common_0.7.3-2.1+squeeze2_i386.deb
7eff948228d1ae5502e8c76122ee42a0a5bd5db6 190396 ettercap_0.7.3-2.1+squeeze2_i386.deb
1b24eec0ff0367695eb322ab98d5e82eb436342e 227130 ettercap-gtk_0.7.3-2.1+squeeze2_i386.deb
Checksums-Sha256:
4d0110313861e50a182ce5536a69aaa7bcfd5783bc8d95b12abdd63294477a68 942 ettercap_0.7.3-2.1+squeeze2.dsc
cdf9c32ec6c13ef7b8eef6be3b56071ad402c6813ca5f1011e9db4c34062819b 6982 ettercap_0.7.3-2.1+squeeze2.diff.gz
021f8af276c76accdca8f12876f68571629d2ef1359b2f341bdacc6c38062620 304050 ettercap-common_0.7.3-2.1+squeeze2_i386.deb
621cf6ee9330c25c057aef9ee4e353ac2803ca5fef06d72ca3ba00fe893becd8 190396 ettercap_0.7.3-2.1+squeeze2_i386.deb
8cca8d050639c16e1e31f8d02633a023a2e2a52a87bb3a7dd0d29c13bc9851d0 227130 ettercap-gtk_0.7.3-2.1+squeeze2_i386.deb
Files:
dca8f508f6966a5fa46406cd0ba8e148 942 net optional ettercap_0.7.3-2.1+squeeze2.dsc
655865176aa5667467c6427c5a920a86 6982 net optional ettercap_0.7.3-2.1+squeeze2.diff.gz
41f3a3b371f6982a22b279c19a73e36b 304050 net optional ettercap-common_0.7.3-2.1+squeeze2_i386.deb
6ff0029fa58bc8a617603c30f2bb851b 190396 net optional ettercap_0.7.3-2.1+squeeze2_i386.deb
265c3471c8837d8137dacd945d5fbb84 227130 net optional ettercap-gtk_0.7.3-2.1+squeeze2_i386.deb
--
This mail was scanned by BitDefender
For more information please visit http://www.bitdefender.com
Reply to: