--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: bamf: FTBFS with GLib 2.62: uses deprecated G_TYPE_INSTANCE_GET_PRIVATE with -Werror
- From: Simon McVittie <smcv@debian.org>
- Date: Fri, 13 Sep 2019 09:39:47 +0100
- Message-id: <20190913083947.GA30166@espresso.pseudorandom.co.uk>
Source: bamf
Version: 0.5.4-1
Severity: important
Tags: ftbfs
Control: block 940161 by -1
To reproduce, build bamf against glib2.0 2.62.x, currently in experimental.
glib2.0 2.62.x is part of GNOME 3.34 and will be uploaded to unstable soon,
at which point this bug will become RC.
bamf uses compiler options that include -Werror and
-Wno-error=deprecated-declarations:
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -Wdate-time
> -D_FORTIFY_SOURCE=2 -Wall -std=c99 -fPIC -DDATADIR=\"/usr/share\"
> -I. -I../../lib -I../../lib -pthread -I/usr/include/gio-unix-2.0
> -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/glib-2.0
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2
> -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> -Werror=format-security -Wall -Werror -Wno-error=deprecated-declarations
> -Wempty-body -Wformat-security -Winit-self -Warray-bounds
> -Wimplicit-function-declaration -lm -c bamf-application.c -fPIC -DPIC
> -o .libs/libbamf3_la-bamf-application.o
GLib 2.62.x has started to apply deprecation warning markers to
deprecated non-declaration constructs, such as macros and types. In
particular this affects the G_TYPE_INSTANCE_GET_PRIVATE macro,
which is part of the implementation of older conventional macros like
BAMF_APPLICATION_GET_PRIVATE. Because this is not actually a declaration,
it is unaffected by -Wno-error=deprecated-declarations:
> bamf-application.c: In function ‘bamf_application_class_init’:
> bamf-application.c:714:3: warning: ‘g_type_class_add_private’ is deprecated [-Wdeprecated-declarations]
> 714 | g_type_class_add_private (obj_class, sizeof (BamfApplicationPrivate));
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/glib-2.0/gobject/gobject.h:24,
> from /usr/include/glib-2.0/gobject/gbinding.h:29,
> from /usr/include/glib-2.0/glib-object.h:23,
> from /usr/include/glib-2.0/gio/gioenums.h:28,
> from /usr/include/glib-2.0/gio/giotypes.h:28,
> from /usr/include/glib-2.0/gio/gio.h:26,
> from ../../lib/libbamf-private/bamf-gdbus-generated.h:11,
> from ../../lib/libbamf-private/bamf-private.h:23,
> from bamf-application.c:38:
> /usr/include/glib-2.0/gobject/gtype.h:1308:10: note: declared here
> 1308 | void g_type_class_add_private (gpointer g_class,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> bamf-application.c: In function ‘bamf_application_init’:
> bamf-application.c:746:13: error: G_ADD_PRIVATE [-Werror]
> 746 | priv = self->priv = BAMF_APPLICATION_GET_PRIVATE (self);
> | ^~~~~~~~~~~~~~~
The obvious solution is to stop compiling distro packages with -Werror,
which is nearly always a RC bug waiting to happen. Untested patch:
edit this line in configure.ac
CFLAGS="$CFLAGS -Wall -Werror -Wno-error=deprecated-declarations -Wempty-body -Wformat-security -Winit-self -Warray-bounds -Wimplicit-function-declaration -lm"
and remove -Werror.
Unfortunately this setup *appends* to CFLAGS rather than using a separate
variable or prepending to CFLAGS, so it is not possible to avoid -Werror
by using "make CFLAGS=-Wno-error" or similar. Autotools best-practice
is to reserve CFLAGS for use by the user, and use a separate variable
for flags requested by the upstream maintainer. It would probably
be worthwhile to talk to upstream about a more distro-friendly setup
for CFLAGS, such as using a separate variable like WARNING_CFLAGS for
the compiler warnings, using the standard Libtool macro LT_LIB_M to
populate $(LIBM) instead of hard-coding -lm, and having a straightforward
way to disable -Werror - or perhaps using the autoconf-archive macro
AX_COMPILER_FLAGS, which adds a --disable-Werror option suitable for
use by distros.
smcv
--- End Message ---
--- Begin Message ---
Source: bamf
Source-Version: 0.5.4-2
We believe that the bug you reported is fixed in the latest version of
bamf, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 940164@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mike Gabriel <sunweaver@debian.org> (supplier of updated bamf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 05 Nov 2019 10:33:50 +0100
Source: bamf
Architecture: source
Version: 0.5.4-2
Distribution: unstable
Urgency: medium
Maintainer: Debian+Ubuntu MATE Packaging Team <debian-mate@lists.debian.org>
Changed-By: Mike Gabriel <sunweaver@debian.org>
Closes: 940164 942913
Changes:
bamf (0.5.4-2) unstable; urgency=medium
.
[ handsome_feng ]
* debian/patches:
+ Add 1003_add-compile-warning-flags.patch. Add enable-compile-warnings
to configure.ac. (Closes: #940164)
.
[ Mike Gabriel ]
* debian/{compat,control}:
+ Use debhelper-compat notation. Bump to DH compat level version 12.
* debian/rules:
+ Use dh_missing override instead of dh_install --fail-missing.
+ Set --without autoreconf, handled by autogen.sh.
* debian/control:
+ Bump Standards-Version: to 4.4.1. No changes needed.
+ Add Rules-Requires-Root: field and set it to no.
+ Update B-D python-libxslt1 -> python3-lxml. (Closes: #942913).
* debian/patches:
+ Fix typo in 1003_add-compile-warning-flags.patch
+ Add 1004_py2to3_gtester2xunit.patch. Use python3 for gtester2xunit.py.
Port libxml2/libxslt module usage to lxml module usage.
* debian/bamfdaemon.install:
+ New file location for bamfdaemon and bamfdaemon-dbus-runner (libexec
dir).
Checksums-Sha1:
a08d27954d8b99035f1166daf9f1c2acd9ff7d02 2403 bamf_0.5.4-2.dsc
9d1213e0de73dfeb9da859f3bab2ba1d296d6a28 18128 bamf_0.5.4-2.debian.tar.xz
8bf2cbd21723da1a4b8a65e07c168e3ad16b679f 17510 bamf_0.5.4-2_source.buildinfo
Checksums-Sha256:
496dcf41aa01e48065b80dc2b5bdc6a6bf41bb20f2252f553b134a16897fddaf 2403 bamf_0.5.4-2.dsc
ac3990e752f2aa3942756b4f9d9e9e71b1010ff3fe599d12feccbe5f09479cb6 18128 bamf_0.5.4-2.debian.tar.xz
e82c9d8878cfe7986b198879815e8f492f78ffe90ba1bbb6d554aae8cb06a2d3 17510 bamf_0.5.4-2_source.buildinfo
Files:
3eb7499b7faf57e6a20778a2d2477350 2403 libs optional bamf_0.5.4-2.dsc
49fcc813fddd0f595e52d63d1a57f84b 18128 libs optional bamf_0.5.4-2.debian.tar.xz
5dc5e450bad15829d8e185d281c378ff 17510 libs optional bamf_0.5.4-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJJBAEBCAAzFiEEm/uu6GwKpf+/IgeCmvRrMCV3GzEFAl3BbnoVHHN1bndlYXZl
ckBkZWJpYW4ub3JnAAoJEJr0azAldxsxlMsP/jSAnlHA70WlgmuPe6fZBlz6Xqd1
+y0pOcViszFyEK4mfNQ6sD/GLg8ilGmeECDD9+iopCGV8Hs11NQBYkUypb8MpJ9s
+104y0O6bJKJu+zSFFkkrKqsjIptYDG3/Ox6tU48ghkQmiBKwsSAxeDpnpNi7Z38
SH7rVAG+NNUhntct/ulEXJiELTVow5tugFmCQqSx18KBcHUCqJr2otnbmpIFrsRd
jNBysHmZM7FqcbgcnMEMNv4iAsEElAThPs5sEHqfxl4x1Ou2pTz5DHq+6Gq3qhTd
jBR9qxfVsL7Oxn0d1q4bQPSO84Y2ynqS6aF+oxWfgNZvuS/Els3rSNWT7Oj/T0KD
mDwoJydGUPrL6IMTEmbpsVE9s/CdZWknXvWWDlEs79Qsr+HkJc47NkvyPEMZX9b0
xClA5GRnP2wZ5M7DQeOv8/EkFX9nh/zDoP6y/LDpVZ4gRJMuPmjDuN0w+gjJl0jX
ryzYNBBt6NQBjUUWmvm+r2l/P50GI8v5qsE4QS58Dj94TpdG2y/6OihTm6Gitgdz
kR4oU50/tNcKgZ3JgHnI+9SmbhLOWkIn6doTMtFhZqcPKlcDcQSpiqppujOOQXAo
wR6vfYXs6cpLOUWPjhsJpQqk833Gr2L4q+7yfZECtvtLTDlxG/e7VaDW5X3Ul0P5
/ueI9oZoVsZ4fdjU
=aMm4
-----END PGP SIGNATURE-----
--- End Message ---