[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: C++ issue in latest unanimity (packaging refreshed, but may be tiny stumbling C++ stone for me)




On 10/10/2018 03:12 PM, Olivier Sallou wrote:
>
> On 10/10/2018 03:09 PM, Andreas Tille wrote:
>> On Wed, Oct 10, 2018 at 02:56:55PM +0200, Olivier Sallou wrote:
>>>>    include/pacbio/ccs/ConsensusSettings.h
>>> looking a src/CmakeLists, libunanimity.a should contain all .h fields in
>>> include dir , but looking at generated file, no pacbio/ccs/... related
>>> symbols are found
>>>
>>> add_library(unanimity STATIC
>>>     ${UNANIMITY_FILES}
>>> )
>>>
>>> with UNANIMITY_FILES containing UNY_HEADER, which should match all
>>> include header files (file(GLOB_RECURSE UNY_HEADER "${UNY_IncludeDir}/*.h"))
>> I admit I have no idea how to turn this information into a patch.
> I have for the moment no idea on how to fix.
> I just describe what is in build system, and it should work as it says
> to include all include/../*.h in library. don't know why it does not work.
>
> I am investigating anyway
>> Could you commit some code that helps building? ;-)
I found a fix (there are some other errors after that)

--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -114,6 +114,7 @@
     SubreadResultCounter.cpp
     Timer.cpp
     Utility.cpp
+    ConsensusSettings.cpp
 )


not sure this is the best fix, but it works. Looks related to
PYTHON_SWIG which is set to ON in d/rules. In this case some files are
not included.
I have pushed my patch to git repo

Remaining errors are related to missing binaries:

   dh_install -O--package=unanimity -O--no-package=python-consensuscore2
-O--buildsystem=cmake -O--builddirectory=build
dh_install: Cannot find (any matches for) "/usr/bin/juliet" (tried in .,
debian/tmp)

dh_install: unanimity missing files: /usr/bin/juliet
dh_install: Cannot find (any matches for) "/usr/bin/fuse" (tried in .,
debian/tmp)

dh_install: unanimity missing files: /usr/bin/fuse
dh_install: Cannot find (any matches for) "/usr/bin/cleric" (tried in .,
debian/tmp)

dh_install: unanimity missing files: /usr/bin/cleric


those files are not generated....
>>
>> Thanks for looking into this
>>
>>       Andreas.
>>
>>
>>>>>> [1] https://salsa.debian.org/med-team/unanimity

-- 
Olivier Sallou
Univ Rennes, Inria, CNRS, IRISA
Irisa, Campus de Beaulieu
F-35042 RENNES - FRANCE
Tel: 02.99.84.71.95

gpg key id: 4096R/326D8438  (keyring.debian.org)
Key fingerprint = 5FB4 6F83 D3B9 5204 6335  D26D 78DC 68DB 326D 8438



Reply to: