[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: indelible



Hi Fabian,
I added log.txt by mistake, and I've removed it now. I've also added reference data, added a randomseed parameter to input files, and changed run-unit-test to compare the output files as well. The autopkgtests pass in a clean chroot. Please take a look.

Regards,
Pranav

On Fri, Jun 12, 2020 at 1:35 AM Fabian Klötzl <kloetzl@evolbio.mpg.de> wrote:
Hi Pranav,

Thank you for your work on this. I have just two comments. For one the
repo now contains a file log.txt which I think you might have added by
accident. Secondly, your test check whether the program runs. However,
they don't actually check whether it runs correctly. You could add a
randomseed parameter to the files and diff the result with one you
precomputed on your local machine. If there is a difference, have the
autopkgtest fail. It will be a bit fiddly to get to work on all
platforms, but would be could if we had that.

Best,
Fabian


On 11.06.20 21:28, Pranav Ballaney wrote:
> Hi,
> I've added autopkgtests to indelible. Please review and sponsor.
> https://salsa.debian.org/med-team/indelible
>
> Regards,
> Pranav
> ᐧ


Reply to: