Re: request for package review - serel

[Colin Watson <cjwatson@debian.org>]

On Fri, Aug 02, 2002 at 04:51:32PM +0200, Andreas Metzler wrote:
> In article <[🔎] 3D48F029.C7D3A981@moniker.net> Leni Mayo <leni@moniker.net> wrote:
> > As this is the first release on debian, I'd be grateful if someone
> > with more packaging experience than myself could take a look at it,
> > especially since the installation process patches /etc/init.d/rc.
> > The .deb is at: http://www.fastboot.org/download/binaries/debian/
> 
> Hello!
> * lintian serel_0.3.4-1.dsc
>   W: serel source: out-of-date-standards-version 3.0.1
>   E: serel source: package-uses-debhelper-but-lacks-build-depends

Also:

  $ lintian serel_0.3.4-1_i386.deb 
  E: serel: file-in-etc-not-marked-as-conffile etc/default/serel
  E: serel: file-in-etc-not-marked-as-conffile etc/init.d/rc.serel.include
  E: serel: file-in-etc-not-marked-as-conffile etc/serel/serel.conf
  E: serel: file-in-etc-not-marked-as-conffile etc/serel/default.rdf
  E: serel: unregistered-script-in-etc-init.d /etc/init.d/rc.serel.include
  E: serel: non-standard-file-permissions-for-etc-init.d-script etc/init.d/rc.serel.include 0644 != 0755
  W: serel: package-contains-upstream-install-documentation usr/share/doc/serel/INSTALL
  W: serel: extra-license-file usr/share/doc/serel/COPYING.gz

(You can run lintian over the .changes file to check both at once.)

At least the first four are serious - they mean that configuration file
changes won't be preserved on upgrades. The fifth and sixth may also be
a problem depending on how you're interacting with other init script
subsystems - I haven't looked at the details.

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]