On Mon, Dec 10, 2007 at 07:29:39PM +0100, Carlos Martín Nieto wrote:
>
> On lun, 2007-12-10 at 11:35 -0600, Luis Rodrigo Gallardo Cruz wrote:
> > On Mon, Dec 10, 2007 at 06:25:34PM +0100, Carlos Martín Nieto wrote:
> > >
> > > On dom, 2007-12-09 at 16:52 -0600, Luis Rodrigo Gallardo Cruz wrote:
> > > > > You can find it at http://www.cmartin.tk/blam/blam_1.8.4-3.dsc
> > I had a first look through the package. Several of the debian patches
> > look like they belong upstream. Since you're him ;) Is there a reason
> > they have not been included?
>
> Indeed there is. Those patches were made after the 1.8.4 version was
> released and there isn't going to be a 1.8.5 version (well, that was the
> plan, I may yet release it) those patches end up in Debian. They are
> upstream, just in a later version.
Ok, good enough.
> > Also, some changes from -2.1 to -3 are patches to upstream but are not
> > in a separate patch but included in the .diff.gz Please separate them.
>
> I think the reason Makefile.{am,in} are patched directly is because the
> patches are applied too late in the process and by then the Makefile has
> already been created.
Mmm. cdbs at work.
Ok, if you can't get them to apply soon enough, it's ok to leave those
(but just those) directly in the .diff.gz.
A few more comments:
dpkg-shlibdeps complains about many unnecesary libraries linked to
libblam.so. It would be good if you could check upstream's build
systema and try to eliminate them, but this is not a show stopper and
can well wait for another release.
I get the following warning:
dh_clideps: Warning! No Build-Depends(-Indep) on cli-common-dev (>= 0.4.4)!
dh_clideps: Warning: Could not resolve moduleref: libblam.so for: blam.exe!
dh_clideps: Warning: No Debian dependency data for Atom.NET (0.4.3.27119__dfd513aadd65a3d3)!
I don't know enough about mono to know how serious these are, so
please either fix them or explain to me why it's not needed ;)
linda complains that:
E: blam; Uses cdbs and debhelper.mk, but debhelper Build-Depends is too old.
This package uses cdbs and includes debhelper.mk, but the version of
debhelper the package Build-Depends on is too old. To use
debhelper.mk you currently must Build-Depend on at least debhelper (>=
4.1.0).
lintian complains that:
W: blam source: out-of-date-standards-version 3.7.2 (current is 3.7.3)
Please check if the new changes to policy apply to your package and
update Standard-versions accordingly.
W: blam: description-contains-homepage
Please move the Homepage from inside the description into its own
control field, which is now supported.
I: blam: desktop-entry-contains-encoding-key /usr/share/applications/blam.desktop:3 Encoding
That's for your upstream ;) .desktop files should no longer include
the Encoding entry, it's now obligatory to encode them in utf8.
(BTW. Always use the lintian from unstable to check your packages.)
*******
Otherwise, your package looks good. The only changes I will insist on
are the updating of standards-version and the explanation about the
dh_clideps warnings.
Attachment:
signature.asc
Description: Digital signature