[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gnome-icon-theme-faenza



Hi,

Le vendredi 18 mars 2011 à 22:54:48 (+0100 CET), Adnan Hodzic a écrit :
> > On Fri, Mar 18, 2011 at 8:47 PM, Adam Borowski <kilobyte@angband.pl> wrote:
> > The icon for the icon theme itself is missing or invalid -- I get the Gnome
> > logo instead of a "directory" icon.
> 
> Fixed(?)

Still the same issue (this is in gnome-appearance-properties, in the
icons tab).

> Please take a look at the re-uploaded package, I double checked all the
> errors with different users machines and it seems to be working fine.
> I also made it 100% lintian clean
> this time.

The debian/dirs file is useless and I'd remove comments in debian/rules.

Your copyright file is yet to be improved to fulfill DEP5 requirements.

Also, you state the icons are licensed under the GPL-3+ but the short name
is GPL and I cannot find where you have found they could be distributed
under a later version og the GPL. If you had this from upstream in an email,
quote it in the copyright file.

I also wonder whether it wouldn't be better to split the various themes in 3
different packages given the size of the unique package (13M). What do you
think?

Cheers,
Julien

-- 
  .''`.   Julien Valroff ~ <julien@kirya.net> ~ <julien@debian.org>    
 : :'  :  Debian Developer & Free software contributor
 `. `'`   http://www.kirya.net/
   `-     4096R/ E1D8 5796 8214 4687 E416  948C 859F EF67 258E 26B1


Reply to: