[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#667902: RFS: downtimed/0.5-2



owner 667902 !
tags 667902 +moreinfo
thanks

Hi Mats Erik,

as promised a took a look at your package. I am willing to sponsor you
if you address these corrections:

* You use dpkg-buildflags but you didn't declare a versioned
build-dependency against dpkg-dev which explicitly supports "--export
*FLAGS" (1.16.1 I think). My rule of thumb is to declare
build-dependencies against build-essential packages if you use features
not satisfied in stable. Otherwise you break backports and such without
notice.

* Please document why you are overriding
init.d-script-possible-missing-stop. For the other Lintian tag you
override I can see your point, but I personally wouldn't bother since
you require $remote_fs in start anyway. If you want, that's fair enough.

* Not sure about your rationale to override dh_installinit either. The
whole point of LSB headers is to determine the dependencies out of them.

Otherwise you did good work as I used to know from you.

-- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: