[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#669598: RFS: python-django-djblets/0.6.17-1 [ITP] -- Collection of useful extensions for Django



* Dmitry Nezhevenko <dion@dion.org.ua>, 2012-04-25, 11:46:
Yes. Will fix. But how can I handle these js files? There are actually
three versions of "minified" jQuery:

jquery-1.3.2.min.js

This one is jQuery...

jquery-ui-1.6rc2.min.js
jquery-ui-1.6rc5.min.js

...and these two is jQuery UI (a user interface library for jQuery). Not sure why two versions are needed. I don't see any reference to 1.6rc2 in the code.

If it will work, is it enough to just not use/remove these embedded versions? Or I should repack upstream tarball?

You have the following options:
1) Repack the tarball.
2) Include the source somewhere in debian/ (in that case please mention the fact in the copyright file; otherwise ftp-masters might miss it while reviewing the .orig.tar!).
3) Ask upstream to provide the source in their tarballs.

Option 3 is preferable, but it also might be the hardest one.

jQuery UI has also a different copyright holder than jQuery proper, so if you choose 2) to 3), you need to reflect that in the copyright file.

Oh, and looking again at jQuery UI, it's even worse than "just" missing source: it's undistributable. The license is GPL or MIT. The GPL requirements are obviously not satisfied. The MIT requirements ("The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.") are not satisfied either.

Upstream provides a test suite. Please run it at build time, against all supported Python versions.
Some of these tests are known-to-fail outside of specially configured environment. How this should be handled?

Is it feasible to create such specially configured environment in debian/rules? If yes, do it. :)

--
Jakub Wilk



Reply to: