Vincent, Le 17/05/2015 01:39, Vincent Cheng a écrit : > Hi Rodolphe, > > On Sat, May 16, 2015 at 1:23 PM, Rodolphe PELLOUX-PRAYER > <rodolphe@damsy.net> wrote: >> Hi Vincent, >> >> Thx for your review! >> >>> debian/copyright is missing a few entries: >>> - src/serial/*: Copyright 1997-2001 John E. Stone (j.stone@acm.org), >>> 3-clause BSD (+ upstream author) >> >> Should be fixed. > > You're also missing Thomas Anderson <ta@nextgenengineering.com> as the > copyright holder for a number of files in src/magellan/. (In case you > haven't done so already, please take the time to do a thorough > license/copyright check yourself when adopting/packaging new > packages.) Damn, you're right, I definitely need to check more carefully the licenses and copyrights! licensecheck seems to be a good helper :) > By the way, I also suggest that you use start-stop-daemon in your > sysvinit script, especially since you're shipping a script of your own > here. Init script updated. The new version is there : http://mentors.debian.net/package/spacenavd Regards, Rodolphe
Attachment:
signature.asc
Description: OpenPGP digital signature