[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823663: RFS: tio/1.6-1 [ITP] -- The simple TTY terminal I/O application



* Jakob Haufe <sur5r@sur5r.net>, 2016-05-07, 12:04:
https://mentors.debian.net/debian/pool/main/t/tio/tio_1.6-1.dsc

The short license name in d/copyright should be "GPL-2+".

Please run autoreconf at build time. (That should be a matter of replacing the "autotools-dev" addon with "autoreconf".)

My git doesn't like the certificate:
fatal: unable to access 'https://git.sur5r.net/tio/': server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none

If this is expected, then it would be probably useful to add a comment to d/control explaining how to persuade git to disable certificate verification.

Please ask upstream to build with -Wall (and then fix the warnings...).

Upstream changelog seems to cover only changes from the previous version. This is unimportant for the initial release, but in the future we'll need at least all changes from stable to stable+1 included. Please talk to upstream about their changelog habits. :)

Lintian says:

P: tio source: debian-watch-may-check-gpg-signature
X: tio: binary-file-built-without-LFS-support usr/bin/tio

Please talk to upstream about signing their releases.

The LFS thing is probably not very important. The only regular files that tio opens are log files, which are unlikely to grow over 2GB. But upstream might want to fix it anyway. This should be a matter of adding AC_SYS_LARGEFILE to configure.ac.

--
Jakub Wilk


Reply to: