On Sun, Feb 25, 2018 at 11:14:37PM +0100, Kai Harries wrote: > > The source package you've uploaded is broken, as .dsc mentions > > nix_1.11.15-2~a1.debian.tar.xz. > > My fault, GitHub doesn't like '~' in file names so I have uploaded > the files with an '.' instead of '~'. I have uploaded a new version [1] > that does not use the '~' in the version. Thank you. Please use verbose build output. Please switch to the current debhelper compat level. The Vcs-* tags don't point to the packaging repo. You hardcode "perl5/site_perl/5.26.1/x86_64-linux-gnu-thread-multi" in d/rules. Does the package really need to include development files? The source ships embedded code copies of at least bsdiff and parts of boost. It even builds and installs bsdiff and bspatch binaries. And the copyrights and licenses of this source are not listed in d/copyright. Putting the whole LGPL in d/copyright is wrong. And it says "LGPL-2.1" while the manual says "LGPL-2.1+". src/libexpr/parser-tab.* and doc/manual/style.css licenses are not mentioned in d.copyright. > > The version, 1.11.15-2~a1, is wrong for an initial Debian upload. > > I have used 1.11.16-1 now. But I am not 100% sure that this is an > correct version number for the initial upload!? It is, why not? > > Also, the version in the RFS subject is not the package version. > > My fault I missed a number in my RFS. What should I do to fix > this. Create a new RFS? (BTW I have now taken a newer upstream version). You should retitle this one. > > You need to run lintian from unstable on your package and fix main issues > > before asking for sponsorship. > > Only two warnings left: > > W: nix: manpage-has-errors-from-man usr/share/man/man1/nix-store.1.gz 1235: warning [p 13, 9.7i]: can't break line > W: nix: binary-without-manpage usr/bin/nix-generate-patches That's definitely not true. E: nix changes: unreleased-changes W: nix source: debhelper-tools-from-autotools-dev-are-deprecated dh ... --with autotools_dev (line 18) P: nix source: package-uses-old-debhelper-compat-version 9 W: nix source: build-depends-on-obsolete-package build-depends: dh-systemd => use debhelper (>= 9.20160709) I: nix source: out-of-date-standards-version 3.9.8 (released 2016-04-06) (current is 4.1.3) I: nix source: testsuite-autopkgtest-missing X: nix source: upstream-metadata-file-is-missing P: nix source: debian-watch-does-not-check-gpg-signature I: nix: hardening-no-fortify-functions usr/bin/nix-daemon I: nix: hardening-no-fortify-functions usr/bin/nix-instantiate I: nix: hardening-no-fortify-functions usr/bin/nix-store I: nix: hardening-no-fortify-functions ... use --no-tag-display-limit to see all (or pipe to a file/program) I: nix: spelling-error-in-binary usr/bin/nix-collect-garbage refered referred I: nix: hardening-no-bindnow usr/bin/nix-collect-garbage I: nix: spelling-error-in-binary usr/bin/nix-daemon refered referred I: nix: hardening-no-bindnow usr/bin/nix-daemon I: nix: spelling-error-in-binary usr/bin/nix-env refered referred I: nix: hardening-no-bindnow usr/bin/nix-env I: nix: spelling-error-in-binary ... use --no-tag-display-limit to see all (or pipe to a file/program) I: nix: hardening-no-bindnow ... use --no-tag-display-limit to see all (or pipe to a file/program) P: nix: no-upstream-changelog I: nix: spelling-error-in-copyright GNU Library Public License GNU Library General Public License W: nix: package-installs-deprecated-upstart-configuration etc/init/nix-daemon.conf W: nix: pkg-config-unavailable-for-cross-compilation usr/lib/pkgconfig/nix-expr.pc W: nix: pkg-config-unavailable-for-cross-compilation usr/lib/pkgconfig/nix-main.pc W: nix: pkg-config-unavailable-for-cross-compilation usr/lib/pkgconfig/nix-store.pc W: nix: manpage-has-errors-from-man usr/share/man/man1/nix-store.1.gz 1235: warning [p 13, 9.7i]: can't break line W: nix: binary-without-manpage usr/bin/nix-generate-patches I: nix: possible-documentation-but-no-doc-base-registration X: nix: shlib-calls-exit usr/lib/nix/libnixexpr.so X: nix: shlib-calls-exit usr/lib/nix/libnixmain.so X: nix: shlib-calls-exit usr/lib/nix/libnixstore.so I: nix: systemd-service-file-missing-documentation-key lib/systemd/system/nix-daemon.service I: nix: systemd-service-file-missing-install-key lib/systemd/system/nix-daemon.service -- WBR, wRAR
Attachment:
signature.asc
Description: PGP signature