Hi Matthias,
As part of my Debian Developer application, I reviewed your package
"neo-cli" as posted on mentors.debian.net. I found a few issues that
should be addressed before this package could be uploaded. While I'm
not yet a DD, if you fix the following issues and no one else sponsors
this package for you before I become a DD, I'd consider sponsoring it.
Packaging review for neo-cli 0.6.1-1, uploaded 2022-08-25 20:36 to
mentors.debian.net:
* Did you see that a similar program is already included in Debian
(cmatrix)? Is there something that this program does
better/different/additional when compared to cmatrix?
* In d/control, the section should probably be "games" or "misc", not
"admin".
* In d/control, the resources pointed to by the Vcs-* fields are not
publicly viewable; please fix permissions as needed and/or correct the
URLs.
* d/copyright has errors that will cause a REJECT by ftpmaster:
- You list the license as GPL-3, but the license text is for GPL-2+
- Looking at the source files, the license seems to be GPL-3+,
although that conflicts with what's stated in the README.md file. You
should ask the upstream developer if README.md should also state "GNU
GPL v3+". In either case, make sure d/copyright is updated correctly.
- The upstream copyright should be "2021 Stewart Reive" to match
what is in the source code. I don't know where the email address that's
currently listed (3587451+st3w@users.noreply.github.com) came from, as
it doesn't appear anywhere in the upstream code.
* Running linitian reports some "info" level messages -- have you
looked at resolving those before upload?
Mathias
Attachment:
signature.asc
Description: This is a digitally signed message part