Bug#1050814: RFS: qbootctl/0.1.2-1 [ITP] -- utility to control Quacomm A/B boot slots

[Roger Shimizu <rosh@debian.org>]

Thanks, Dmitry, for the prompt fix/update!

On Sat, Sep 2, 2023 at 2:09 PM Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
>
> On Sat, 2 Sept 2023 at 11:23, Roger Shimizu <rosh@debian.org> wrote:
> > Thanks for your ITP & RFS!
> >
> > Some nitpicking:
> > * debian/README.Debian:
> >   Please add more description, or remove this file.
>
> Ack. I've updated the package  to drop this file (and also to include
> the qbootctl.service file to mark the boot as successful
> automatically).
>
> > * debian/include/scsi/scsi_bsg_ufs.h
> >   This header is not upstreamed yet?
>
> This header comes from the Linux kernel itself. It is a part of uABI.
>
> >   Is it possible to use existing debian packaged header?
>
> Unfortunately, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050368

Above ticket is in pending status, so the next upload should fix the issue.
So please update this package accordingly then.

> > * Do you know whether this package works for QCOM LE / LU baseline systems?
>
> Most likely, the Linux kernel API and the bootloader are the same. But
> I don't think anybody tested it with LE / LU.

OK. We can test it easily when it hit Debian archive.

I'll upload it later.
But hope you can also fix the lintian in the future:

W: qbootctl: no-manual-page [usr/bin/qbootctl]
I: qbootctl: package-supports-alternative-init-but-no-init.d-script
[lib/systemd/system/qbootctl.service]
I: qbootctl: systemd-service-file-missing-documentation-key
[lib/systemd/system/qbootctl.service]

Thank you for your contribution to Debian!

Cheers,
Roger

>
> --
> With best wishes
> Dmitry