Hello Alexandru, Thank you for the ping :) Alexandru Mihail <alexandru.mihail2897@gmail.com> writes: > I've commited and pushed the changes to the remote I was using for the > MR so far: > commit: > https://salsa.debian.org/alexandru_mihail/mini-httpd/-/commit/fc7c4f664dc1369b1bf5d46c8c9b7aa11de68407 > > > But I think I may have not commited where I was supposed to, granted > you've already closed the MR. You committed in the right place, and yes, as requested pushed to the remote in your personal namespace rather than to the collaborative space where mini-httpd is maintained. Yes, this is what I asked for, because I wanted to make sure everything was in good order before uploading to the archive and asking you to push to the actual project (thus making it permanent). I'm pulling from your remote directly rather than using the gitlab now. Tags on the actual project are immutable (or should be treated thus), and should only be pushed after an upload has been accepted, and this is why I wanted to check that everything was 100% good. Yes, I had already merged your MR, and MRs are automatically closed when they're merged. > I've already created a GPG signed tag accessible at: > https://salsa.debian.org/alexandru_mihail/mini-httpd/-/tags/debian%2F1.30-4 Thanks! > The commit is not visible in the previous MR: > https://salsa.debian.org/debian/mini-httpd/-/merge_requests/2? This is because the MR was merged already (and thus already closed and not open for updates). > Is there something I've glanced over here ? Did you realise that you're still committing using your protonmail.ch address (and presumably GPG identity)? Early in this process you switched to a gmail address, and I understood that that was the one that you would be using for for your Debian work. You'll need to update your git config to use the new gmail address and gpg identity (try #debian-mentors on irc.oftc.net if you can't make sense of the docs). Also, at this time please base your work on debian/mini-httpd.git rather than alexandru_mihail/mini-httpd.git. # Fix git config email and gpg identity, then git clone git@salsa.debian.org:debian/mini-httpd.git cd mini-httpd git remote add alex git@salsa.debian.org:alexandru_mihail/mini-httpd.git git fetch alex # just so you have another backup dch -r git commit debian/changelog -m "Release 1.30-4 to unstable." # do your tagging procedure git push --delete alex debian/1.30-4 git push -f alex master debian/1.30-4 Sorry I only noticed this when I manually inspected and compared the tag and release commit on the CLI...I feel like the web-thing hid this information from me, and that might be confirmation bias, but it seems like the same thing happened to you ;) Cheers, Nicholas P.S. FYI, to get Salsa's Gitlab instance to show green verified commits and tags you may also need to update your email address and gpg key there. I don't care about this so long as the actual git data is correct, but you (and/or others) might.
Attachment:
signature.asc
Description: PGP signature