Bug#1051150: RFS: blender-doc/3.6-1 [ITP] -- Blender Manual by the Blender Foundation

[Hugh McMaster <hugh.mcmaster@outlook.com>]

Control: tags -1 moreinfo

Hi Jonathan,

On Sun, 3 Sep 2023 17:51:51 +0300 Jonathan Rubenstein wrote:
> Package: sponsorship-requests
> Severity: wishlist
>
> Dear mentors,
>
> I am looking for a sponsor for my package "blender-doc":
>
>   * Package name     : blender-doc
>     Version          : 3.6-1
>     Upstream contact : Blender Documentation Team <bf-docboard@blender.org>
>   * URL              : https://docs.blender.org/manual/
>   * License          : Apache-2.0, GPL-2.0-or-later, MIT, CC-BY-SA-4.0
>   * Vcs              : https://salsa.debian.org/JJRcop/blender-doc
>     Section          : doc

For your first package, this is great. Now, let's make it even better. :)

d/copyright:
* Please restructure this file so your licence stanzas are at the
bottom. The order of stanzas is header, files, licences.
* Please start filenames/paths and copyright information directly
after the field name, so:
        Files: XXX
        Copyright: XX. Multiple lines can be aligned with spaces.
* You are missing several files that are GPL-licensed. I saw them in
the Add-ons section. Please check every file in the source package
carefully.
* You need to add a copyright stanza for debian/*, attributed to you.
GPL-2.0-or-later is often a good choice here, but it's your decision.

d/control:
* You don't need to specify versions for your (build-)dependencies, as
we're targeting sid/unstable. The exception is debhelper-compat, which
does need to be versioned (= 13).
* In the short and (long) binary package description, please indicate
the manual is in HTML format.

d/rules:
* Please combine your dh_auto_build overrides and exports into a single recipe:

override_dh_auto_build:
        export http_proxy=127.0.0.1:9 https_proxy=127.0.0.1:9 PYTHONPATH=.
        dh_auto_build -- html

* To disable the dh_auto_tests, add `export DEB_BUILD_OPTIONS +=
nocheck` to the top of d/rules and remove the override.
* Please add a line break between each target.

d/upstream/metadata
* Please add the Bug-Database, Bug-Submit and Changelog fields as
flagged by Lintian.

d/source/overrides
* While the line in footer.html is very long, it is not a binary. It's
actually a hyperlink that creates a new bug report upstream.
Please also override the very-long-line-length-in-source-file tag
(refer to your blender-doc mentors page to see what I mean).

d/blender-doc.doc-base:
* Is there a reason you've limited the line length to ~40 characters?
You can go up to 79, although you probably want less so the lines look
more balanced.

d/blender-doc.install:
* Install paths don't need a forward slash (/usr -> usr). You can also
simplify the line to:
        build/html usr/share/doc/blender-doc

* Please run Lintian using `lintian -EviI *amd64.changes` and review the output.
  + Lintian identified some images files that have a .jpg extension
but according to `file` are actually PNG files. You might want to
raise this discrepancy with upstream.
  + Lintian also identified file-references-package-build-path when
blender-doc is built via sbuild. This could be another upstream bug.

----

Once you've addressed all of the points above, please remove the
'moreinfo' tag and I'll have another look. It might take me a few days
to get back to you once you've done that.

Hugh