[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1057124: RFS: harmony/0.7.2-1 [ITA] -- program and library for creating and managing Discord accounts



Hi,


Le 12/12/2023 à 07:57, Paul Wise a écrit :
* Suppress Lintian warning about man page
It is incorrect to suppress valid lintian warnings, instead you should
either ignore them or fix them, probably upstream in this case.

I removed the suppression of the lintian warning and sent the package again.
I plan to generate a manpage using help2man then suggest it upstream after some eventual modifications, I think it can wait for a next version seeing there are only --help and --debug in command line parameters.

While this package isn't possible to autopkgtest easily since it is for
a live proprietary service, you could add superficial testing that the
Python module can be imported; in the Source section of debian/control:

    Testsuite: autopkgtest-pkg-python
Done in the last sent package of today.

These issues may be interesting to work on if you have spare time:

Upstream may like to modernise the Python packaging:

    https://packaging.python.org/en/latest/tutorials/packaging-projects/

pycodestyle/pydocstyle/pyflakes3/pylint/vulture/ruff report some
(likely minor) code issues if you want to contribute fixes upstream.

Looks feasible, also for a next version to have all upstream or do you think all should be done for this version?

Best regards,
--
Patrick ZAJDA

Attachment: OpenPGP_0x9D4AD35BEA273DCA.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: