[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059233: RFS: python-dbutils/3.0.3-1 [ITP] -- tools for providing connections to a database (Python 3)



Control: tags -1 - moreinfo

Hi Jeroen,

Thank you for your feedback.

On 23/12/2023 11:37, Jeroen Ploemen wrote:
> * d/python-dbutils-doc.docs: globbing is supported, might want to
>    make use of that (docs/*).

The lack of globbing was intentional here, since upstream provides a 
copy of the changelog inside the docs directory. Using the glob causes a 
duplicate changelog to be installed, which lintian doesn't like. I've 
left the file as-is for now, but please let me know if you think there's 
a better way to handle this.

> * control: 'Testsuite: autopkgtest-pkg-python' is of little use when
>    combined with a non-trivial autopkgtest.

Very true - removed.

> * d/tests/control specifies a dependency on python3-pytest, which is
>    probably unnecessary as the testsuite runs fine on build without
>    it (a cursory glance suggest it only uses stdlib's unittest).

Thanks. I've got so used to running pytest I missed that it wasn't 
needed here. I've modified the the autopkgtest files to call unittest 
directly and removed the dependency on python3-pytest.

> * lintian hit: P: python-dbutils source: trailing-whitespace
>    [debian/control:27]

Oops, IDE was trying to be helpful - fixed!

> Please remove the moreinfo tag (and CC me directly) once you have an
> updated package ready.

I've reuploaded the package to Mentors with the above modifications. 
Please let me know if you'd like me to do something different with 
d/python-dbutils-doc.docs.

> PS: your domain has its DMARC policy set to 'reject', which is a bad
> idea if you're sending mail to mailing lists; 'quarantine' is usually
> the better choice.

Good shout - fixed.

Many thanks,
Dale Richards

Attachment: OpenPGP_0x9D693E5DAA146CE0.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature.asc
Description: PGP signature


Reply to: