Em 05/03/2024 08:09, Daniel Gröber escreveu:
Hi Lucas, On Mon, Feb 19, 2024 at 04:50:27PM -0300, Lucas Castro wrote:* Package name : foolsmAre you sure you want to change the source package name? Doing so fractures the history of the package on tracker.d.o and it's not really necessary.
The upstream has changed software name but it's a good point about tracker.d.o.
I'll take a look at some project that has changed the name too, BTW I already looked at some of them but not checked the source package name.
Quick package review:
- d/postinst: I don't think it's useful to print the message about editing
the config. I've only seen packages do that in special circumstances, do
you have a justification for it being necessary here?
- You declare Replaces+Conflicts on lsm but you don't seem to take any
care for the new binary package to actually be compatible with the old
one since the config location changed.
I'm in doubt, when the old config exist, if set dpkg to copy the old config from old location to the new one or if I just print/show up a message to users notifying about path update requirement.
If it's good/allowed do the copy, it could be applied in postinst. I think print/show up message is rightest way.
- d/foolsm.init: Still has the old $CONFIG path
That's true, I'll update and re-upload.
--Daniel
Attachment:
OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature