Bug#1065193: RFS: libhx/4.23-1 [RC] -- C library providing queue, tree, I/O and utility functions

[Tobias Frost <tobi@debian.org>]

Hi Jörg,

"debcheckout libhx" still gives me 4.17-1 as head.

After looking at your repo, I think I should point you to DEP-14
as a recommended git layout for packaging. 
As the branch name indicates you are using per-package-revision
branches:
IMHO It makes little sense to have one branch per debian package
version/revision; (I had a similiar discussion on vzlogger lately,
so to avoid repetiions: #1064344#28)

Please clarify how you want to manage the package in git, as
this needs to be reflected in d/control's VCS-* fields correctly.
(this is now blocking the upload.)

(The current fields say the package is maintained in the default branch
of your repo. I see a debian/ directory there, but that one is missing
released (it is at 4.17-1, while unstable is at 4.19-1.1)

The review is based on the .dsc, timestamped on mentors.d.n
2024-03-17 12:00

d/changelog is *STILL* changing history for the 4.19-1 changelog
block. (This issue must be fixed before upload.)

Thanks for re-adding the B-D on dpkg-dev.


So, please elaborate on the git issue (so that the correct VCS-* can be
confirmed or specified) , and fix the rewriting history part, and I'll upload 

Remove the moreinfo tag when ready.

Cheers,
--
tobi

On Sun, Mar 17, 2024 at 01:48:57PM +0100, Jörg Frings-Fürst wrote:
> Hello Tobias,
> 
> thanks for your review.
> 
> 
> Am Donnerstag, dem 14.03.2024 um 17:53 +0100 schrieb Tobias Frost:
> > Control: tags -1 moreinfo
> > 
> > Hi Jörg,
> > 
> > d/copyright:
> > you are changing history:
> > 
> > diff -Naur archive/libhx-4.19/debian/changelog new/libhx-4.23/debian/changelog
> > (...)
> >    * debian/rules:
> >      - Remove build of libhx-dev.symbols.
> > 
> > - -- Jörg Frings-Fürst <debian@jff.email>  Sun, 17 Dec 2023 14:44:39 +0100
> > + -- Jörg Frings-Fürst <debian@jff.email>  Tue, 21 Nov 2023 10:41:07 +0100
> > 
> >  libhx (4.14-1) unstable; urgency=medium
> > 
> > - you git repository seems to missing commits. a debcheckout libhx
> >   gives me 4.17-1 in d/changelog.
> 
> Sorry, that's my mistake.
> 
> > 
> > - please don't drop the Build-Depends: dpkg-dev (>= 1.22.5), the
> >   time_t transition requires it, 
> > 
> 
> Ok. I have add it. 
> 
> > --
> > tobi
> > 
> 
> CU
> Jörg
> 
> -- 
> New:
> GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
> GPG key (long) : 09F89F3C8CA1D25D
> GPG Key        : 8CA1D25D
> CAcert Key S/N : 0E:D4:56
> 
> 
> Jörg Frings-Fürst
> D-54470 Lieser
> 
> 
> git:      https://git.jff.email/cgit/
> 
> Skype:    jff-skype@jff.email
> Jami:     joergfringsfuerst
> Telegram: @joergfringsfuerst
> Matrix:   @joergff:matrix.snct-gmbh.de
> 
> My wish list: 
>  - Please send me a picture from the nature at your home.
> 
> 
> 
>