[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#957217: forked-daapd: ftbfs with GCC-10



On 2020-07-31 12:37:13 +0200, Gianfranco Costamagna wrote:
> control: tags -1 patch
> 
> 
> Description: Fix build with gcc-10
> Author: Gianfranco Costamagna <locutusofborg@debian.org>
> Last-Update: 2020-07-31
> 
> --- forked-daapd-26.4+dfsg1.orig/src/input.h
> +++ forked-daapd-26.4+dfsg1/src/input.h
> @@ -137,7 +137,7 @@ struct input_definition
>  /*
>   * Input modules should use this to test if playback should end
>   */
> -int input_loop_break;
> +static int input_loop_break;
> 
>  /*
>   * Transfer stream data to the player's input buffer. The input evbuf will be
> 
> 
> I uploaded this patch in Ubuntu, fixing the FTBFS.
> (upstream heavily refactored that code, so my suggestion is to move to the new upstream release if possible)

Yes, the patch fixes the FTBFS bug, but is wrong. From its documentation
this should be declared with extern and a definition added to
src/input.c.

Cheers
-- 
Sebastian Ramacher

Attachment: signature.asc
Description: PGP signature


Reply to: