[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#968424: marked as done (Makefile.flext hard codes the build architecture pkg-config)

Your message dated Fri, 18 Sep 2020 17:04:21 +0000
with message-id <E1kJJo5-0003Wd-6d@fasolo.debian.org>
and subject line Bug#968424: fixed in pd-flext 0.6.1-2
has caused the Debian Bug report #968424,
regarding Makefile.flext hard codes the build architecture pkg-config
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
968424: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968424
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: pd-flext-dev
Version: 0.6.1-1
Tags: patch
User: debian-cross@lists.debian.org
Usertags: ftcbfs
Control: affects -1 + src:pd-xsample

pd-xsample fails to cross build from source, because it uses the build
architecture pkg-config. It does so via using Makefile.flext, where it
is hard coded. Please make pkg-config substitutable. I'm attaching a
patch for your convenience.

Helmut

diff --minimal -Nru pd-flext-0.6.1/debian/Makefile.flext pd-flext-0.6.1/debian/Makefile.flext
--- pd-flext-0.6.1/debian/Makefile.flext	2020-03-25 10:11:51.000000000 +0100
+++ pd-flext-0.6.1/debian/Makefile.flext	2020-08-15 06:52:02.000000000 +0200
@@ -32,14 +32,15 @@
 endif
 
 SRCDIR ?= .
+PKG_CONFIG ?= pkg-config
 
 lib.name = $(NAME)
 
 $(NAME).class.sources = $(addprefix $(SRCDIR)/, $(SRCS))
 
-cflags += $(INCPATH) $(DEFS) $(shell pkg-config --cflags pd-flext) $(UFLAGS)
+cflags += $(INCPATH) $(DEFS) $(shell $(PKG_CONFIG) --cflags pd-flext) $(UFLAGS)
 ldflags += $(LIBPATH)
-ldlibs += $(shell pkg-config --libs pd-flext) $(LIBS)
+ldlibs += $(shell $(PKG_CONFIG) --libs pd-flext) $(LIBS)
 
 ifeq (,$(findstring debug,$(MAKECMDGOALS)))
 cflags += $(OFLAGS)
diff --minimal -Nru pd-flext-0.6.1/debian/README.Debian pd-flext-0.6.1/debian/README.Debian
--- pd-flext-0.6.1/debian/README.Debian	2020-03-25 10:11:51.000000000 +0100
+++ pd-flext-0.6.1/debian/README.Debian	2020-08-15 06:52:02.000000000 +0200
@@ -14,4 +14,8 @@
 
 This requires the pd-lib-builder package to be installed.
 
+In a Debian package build, you should invoke make via dh_auto_build:
+
+    dh_auto_build --buildsystem=makefile -- -f /usr/share/pd-flext/dev/Makefile.flext
+
  -- IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>  Tue, 01 Nov 2016 23:49:16 +0100
diff --minimal -Nru pd-flext-0.6.1/debian/changelog pd-flext-0.6.1/debian/changelog
--- pd-flext-0.6.1/debian/changelog	2020-03-25 10:11:51.000000000 +0100
+++ pd-flext-0.6.1/debian/changelog	2020-08-15 06:52:02.000000000 +0200
@@ -1,3 +1,10 @@
+pd-flext (0.6.1-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Make pkg-config substitutable in Makefile.flext. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Sat, 15 Aug 2020 06:52:02 +0200
+
 pd-flext (0.6.1-1) unstable; urgency=medium
 
   * New upstream version 0.6.1

--- End Message ---
--- Begin Message --- 
Source: pd-flext
Source-Version: 0.6.1-2
Done: =?utf-8?q?IOhannes_m_zm=C3=B6lnig_=28Debian/GNU=29?= <umlaeute@debian.org>

We believe that the bug you reported is fixed in the latest version of
pd-flext, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 968424@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org> (supplier of updated pd-flext package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 18 Sep 2020 18:31:54 +0200
Source: pd-flext
Architecture: source
Version: 0.6.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: IOhannes m zmölnig (Debian/GNU) <umlaeute@debian.org>
Closes: 968424
Changes:
 pd-flext (0.6.1-2) unstable; urgency=medium
 .
   * Make pkg-config substitutable in Makefile.flext.
     Thanks to Helmut Grohne <helmut@subdivi.de> (Closes: #968424)
   * Note on how to use Makefile.flext when building Debian-packages.
     Thanks to Helmut Grohne <helmut@subdivi.de>
   * Declare libtool-libs and static libs as not-installed
   * Bump dh-compat to 13
Checksums-Sha1:
 8d24da0699d2bd0ce4b41fcca15b26deef37a8ea 2295 pd-flext_0.6.1-2.dsc
 442c08441f5e8cd992b8dc89ac9186a986c1626f 7824 pd-flext_0.6.1-2.debian.tar.xz
Checksums-Sha256:
 675331c311b594352c83f7d5e379b4b7abaa3c40ea4a45ee7dfc0cac15bec343 2295 pd-flext_0.6.1-2.dsc
 1f897049995d062ad68ce1a20396f3e2e3aef28ade8d791ac4c460e5ac33ea66 7824 pd-flext_0.6.1-2.debian.tar.xz
Files:
 3671d0fa4924989ca91bb60c0a73a76e 2295 libs optional pd-flext_0.6.1-2.dsc
 f17434ced24cc4bb26304273aeb31f56 7824 libs optional pd-flext_0.6.1-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJKBAEBCAA0FiEEdAXnRVdICXNIABVttlAZxH96NvgFAl9k5EsWHGZvcnVtQHVt
bGFldXRlLm11ci5hdAAKCRC2UBnEf3o2+D1LD/93OVcbLjTiQT/oaAho7A1yAi75
Dub4WXQDITm4zAgJsL4vmro66i+lWybHVCTkVnbJ7zbX7kzAxmhHEbW2cmPUSYKO
B/SBN1ousaffAIiZfe9AxHOBLveQn/k2NQvfUF3ClapS/bc1qaWardFw7pUDd47m
7ox/ExJ2Ll1JB7qWxsqTIp5ChB6Z5Qt2EYSNCnCZCQ429uXu56dtvIlQn08OW5SC
wKQdLm8vt5Jvi5ulPiHLxV+LkMFPPSzzaU03qYZUxL+x/MVUh/G1O0dJbCLsBThb
lpN7DhskpUDUcIjQjgwFC+CoLG8xpztHtkscIFW46pMelCRPrdOQBu1PhDGypGE+
wfbgxYyIlP/GqDDONnPezRoInMCJ4gWqMLRBMb7Cn5YAE2+hJstiVRR5fdiMTXe4
1nePyGK/ad6Njhy55AzeQXAcMqXgkGgciJS0kbX6TS8gTG8Jei0xMbW2nIX8Xkzy
RwjYpAlycfh0NOaBNwwetmfvW8wsZ/S5PywfxFaJnX00tF1pfzD2uTaECIVxoKbr
oHuWEM8raWdGupp+ZvjkET3ow0C58epxgxYnkVVFzwqCB2pOYB7sCZa6B7rdGFQ9
7v7UwekBQHLDGB6lJZf+Om/sbbD4EamYDNyi+YYVWzderz7/DvmUvqmSLLy61wBX
CYz5ZPeQ6Y6AxXgNow==
=V9gI
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: