[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#968412: marked as done (photoflow FTBFS: incompatible compiler options)

Your message dated Wed, 11 Nov 2020 07:03:23 +0000
with message-id <E1kckA7-0003St-Ei@fasolo.debian.org>
and subject line Bug#968412: fixed in photoflow 0.2.8+git20200114-2
has caused the Debian Bug report #968412,
regarding photoflow FTBFS: incompatible compiler options
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
968412: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=968412
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: photoflow
Version: 0.2.8+git20200114-1
Severity: important
Tags: ftbfs patch

photoflow fails to build from source on !x86, because it passes
x86-specific compiler options. These should only be present on x86.
Please consider applying the attached patch to make it build elsewhere.

Helmut

--- photoflow-0.2.8+git20200114.orig/src/CMakeLists.txt
+++ photoflow-0.2.8+git20200114/src/CMakeLists.txt
@@ -1,12 +1,26 @@
+SET(GMIC_FLAGS "-Dgmic_build -Dcimg_use_vt100 -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -fpermissive")
 IF(MINGW)
-  SET(GMIC_FLAGS "-std=gnu++14 -march=nocona -mno-sse3 -mtune=generic -Dgmic_build -Dcimg_use_vt100 -Dgmic_is_parallel -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -fno-ipa-sra -fpermissive")
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -std=gnu++14 -Dgmic_is_parallel -fno-ipa-sra")
 ELSEIF(APPLE)
   #SET(GMIC_FLAGS "-DPF_DISABLE_GMIC -std=c++11 -Wno-error=c++11-narrowing -Dgmic_build -W  -Dcimg_use_vt100 -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -Dcimg_use_fftw3_singlethread -fpermissive")
-  SET(GMIC_FLAGS "-march=nocona -mno-sse3 -mtune=generic -Dgmic_build -Dcimg_use_vt100 -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -Dcimg_use_fftw3_singlethread -fpermissive")
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -Dcimg_use_fftw3_singlethread")
   #SET(GMIC_FLAGS "-Wno-error=c++11-narrowing -Dgmic_build -Dcimg_use_vt100 -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -Dcimg_use_fftw3_singlethread -fpermissive")
 ELSE(MINGW)
-  SET(GMIC_FLAGS "-std=gnu++14 -march=nocona -mno-sse3 -mtune=generic -Wno-error=narrowing -Dgmic_build -Dcimg_use_vt100 -Dgmic_is_parallel -Dcimg_use_fftw3 -Dcimg_use_tiff -Dcimg_use_zlib -Dcimg_display=0 -fno-ipa-sra -fpermissive")
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -std=gnu++14 -Wno-error=narrowing -Dgmic_is_parallel -fno-ipa-sra")
 ENDIF(MINGW)
+include(CheckCCompilerFlag)
+check_c_compiler_flag(-no-sse3 HAVE_NO_SSE3)
+IF(HAVE_NO_SSE3)
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -no-sse3")
+ENDIF()
+check_c_compiler_flag(-march=nocona HAVE_MARCH_NOCONA)
+IF(HAVE_MARCH_NOCONA)
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -march=nocona")
+ENDIF()
+check_c_compiler_flag(-mtune=generic HAVE_MTUNE_GENERIC)
+IF(HAVE_MTUNE_GENERIC)
+  SET(GMIC_FLAGS "${GMIC_FLAGS} -mtune=generic")
+ENDIF()
 
 set(COMPILE_FLAGS " ${GMIC_FLAGS} -I${CMAKE_SOURCE_DIR}/src/dt -DLIBRAW_NODLL -DINSTALL_PREFIX='\"${INSTALL_PREFIX}\"' ")
 IF(APPLE)

--- End Message ---
--- Begin Message --- 
Source: photoflow
Source-Version: 0.2.8+git20200114-2
Done: =?utf-8?q?G=C3=BCrkan_Myczko?= <gurkan@phys.ethz.ch>

We believe that the bug you reported is fixed in the latest version of
photoflow, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 968412@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gürkan Myczko <gurkan@phys.ethz.ch> (supplier of updated photoflow package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 10 Nov 2020 15:37:40 +0100
Source: photoflow
Architecture: source
Version: 0.2.8+git20200114-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Multimedia Maintainers <debian-multimedia@lists.debian.org>
Changed-By: Gürkan Myczko <gurkan@phys.ethz.ch>
Closes: 967693 968412
Changes:
 photoflow (0.2.8+git20200114-2) unstable; urgency=medium
 .
   * Apply patch to fix FTBFS, thanks Helmut Grohne. (Closes: #968412)
   * d/rules: Build against gtk3. (Closes: #967693)
   * Bump standards version to 4.5.0.
   * Bump debhelper version to 13.
   * d/upstream/metadata: added.
   * d/control:
     - added Rules-Requires-Root.
     - update build-depends to build against gtk3.
Checksums-Sha1:
 e42a8d4806d63dfd5570c2b904667b1f30c8328d 2128 photoflow_0.2.8+git20200114-2.dsc
 c20af4d8e99f306905ae9435a8eb5dff533f41d2 17504 photoflow_0.2.8+git20200114-2.debian.tar.xz
Checksums-Sha256:
 519c693ed4d73146c86def6268627ea5014576c38b92800c73cc04a43694f841 2128 photoflow_0.2.8+git20200114-2.dsc
 4f515131c011d32ddac71b0011202fa634c1063181e306d45b84488215c3e93e 17504 photoflow_0.2.8+git20200114-2.debian.tar.xz
Files:
 45254860d2c4b0b09d494605ac973c0d 2128 graphics optional photoflow_0.2.8+git20200114-2.dsc
 2b0df2b2cf2809ff4175a4e1c7853503 17504 graphics optional photoflow_0.2.8+git20200114-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEZaEt9P4xrWusTXauM1X01jtYIcwFAl+riVYACgkQM1X01jtY
IcyCOw/9EilyyO9G0/dqPaPNe6FBdq2yr5xOSFcyXOIvDhcuWH4pDEVAb1rIkj97
9ZI8XzOY2o8z30JSNT7Jfq/xm39jcOd3us0FFu+df+eQ1gUw0f8+Gg9Jwfd0JIIT
xYTme6WEF1wfmO+tR0Z2YZc9Zp+iWMkHcGFCw+usG1OzbyXDjoSl4dKHy0Vm/x2x
7ERbkg20AbH5fLzeD0dMAzPQzeyndtImwAgYWJE4x6TrrR5FErEdCL5E4F83DgDu
9gMH9k13vlXDtHq5J7DRFT1VG1DVluwDOv1goA3H4yDb+Xr+omL4M3Zs7UGxxfGR
2/GIv4hoqX6+poluZnwNZFUQeXZ4ORewnbDA4hh4Meu5AOG8aebxvFsGhN3M/YQf
T4XRd9/X4Y87aW8dDeZ7RKEtJaBBNJrYYFNdZFTYm2ZsJln4hYYBT0SlB4WdoQPu
yU6bQ55xhHRXI6Yqa5gsYWe0wTzUWg8YAxU4YwZFnX7TFIyUtBgIk6ZfdF/MLloe
Lz6rfhNCfUQ4xHY/5rRcYGGVgDBsEAebFdas0RdpJ+fa1Lj1n9VVImw6zmBMK5L7
NZu8zrhxnPdRhTrdTU9qUHpN/nB4PIYpsR6zAB2mmvN1ccmSXW4GtnzSUAtT5ERv
6NTRHEdruiFH5mmXk24wnEM1DwGm1+jQLZQbOsh35IpkNY8RZus=
=xFJ+
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: