[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1039457: mplayer: reproducible-builds: version differences caused by /bin/sh implementations



On Sun, 25 Jun 2023 19:12:59 -0700 Vagrant Cascadian wrote:

> The patch to debian/rules fixes this by using a single printf call
> instead of two echo calls, and adjusting the escaped strings
> accordingly.
...
> +	printf "$(OUR_VERSION)\n$(OUR_TITLE)\n"  >> version.h

This is sub-optimal because it means the variable content could be
interpreted by printf, which would mean the output would not be
identical to the variables. This form would avoid that issue:

   printf '%s\n%s\n' "$(OUR_VERSION)" "$(OUR_TITLE)" >> version.h
   
-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: