[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032972: handbrake: debian version of handbrake does not handle subtitles correctly



Hi Michael,
thanks for looking into this!

michael spreng wrote:
> The above mentioned patch to ffmpeg changes ffmpeg to remember the pts. But
> handbrake can remember the pts just as well. So see the attached patch which
> does exactly that: if the subtitle is incomplete, it saves the pts to the
> handbrake subtitle context, and retrieves it if there is no pts on a
> completed subtitle ready for output.
> 
> I am unsure how to proceed from here. Is that fix acceptable? Where would I
> submit it?

Can you please send/propose this upstream, they are in a much better position
to assess this approach.

Either by making a pull request https://github.com/HandBrake/HandBrake or
by opening an issue there.

Cheers,
        Moritz


Reply to: