Bug#1066699: pd-unauthorized: FTBFS: blinkenlights.c:770:9: error: implicit declaration of function ‘error’; did you mean ‘perror’? [-Werror=implicit-function-declaration]
Source: pd-unauthorized
Version: 0.1-7
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> cc -I"/usr/include/pd" -DPD -DVERSION='"0.1"' -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O6 -funroll-loops -fomit-frame-pointer -o "exciter.o" -c "exciter.c"
> blinkenlights.c: In function ‘blinkenlights_open’:
> blinkenlights.c:770:9: error: implicit declaration of function ‘error’; did you mean ‘perror’? [-Werror=implicit-function-declaration]
> 770 | error( "blinkenlights : cannot open >%s<", sfile->s_name);
> | ^~~~~
> | perror
> blinkenlights.c: In function ‘blinkenlights_findframes’:
> blinkenlights.c:629:9: warning: ignoring return value of ‘fgets’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
> 629 | fgets( lineread, BL_MAX_LENGTH, x->x_filed );
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> audience~.c: In function ‘audience_properties’:
> audience~.c:389:45: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 389 | sprintf(buf, "pdtk_audience_dialog %%s %d %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 390 | x->x_width, x->x_height, x->x_nboutputs
> | ~~~~~~~~~~
> | |
> | t_int {aka long int}
> audience~.c:389:48: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 389 | sprintf(buf, "pdtk_audience_dialog %%s %d %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 390 | x->x_width, x->x_height, x->x_nboutputs
> | ~~~~~~~~~~~
> | |
> | t_int {aka long int}
> audience~.c:389:51: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 389 | sprintf(buf, "pdtk_audience_dialog %%s %d %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 390 | x->x_width, x->x_height, x->x_nboutputs
> | ~~~~~~~~~~~~~~
> | |
> | t_int {aka long int}
> audience~.c: In function ‘audience_dialog’:
> audience~.c:516:13: error: implicit declaration of function ‘error’; did you mean ‘perror’? [-Werror=implicit-function-declaration]
> 516 | error( "audience~ : fatal : could not create new object" );
> | ^~~~~
> | perror
> disto~.c: In function ‘disto_init_filters’:
> disto~.c:116:19: warning: iteration 129 invokes undefined behavior [-Waggressive-loop-optimizations]
> 116 | x->exps[i]=exp((double)i*x->x_drive)*x->x_wetmix;
> | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> disto~.c:114:16: note: within this loop
> 114 | for (i=0; i<130; i++)
> | ~^~~~
> audience~.c: In function ‘audience_tilde_setup’:
> audience~.c:1041:22: warning: too many arguments for format [-Wformat-extra-args]
> 1041 | logpost(NULL, 4, "%s", "%s", audience_version );
> | ^~~~
> cc -I"/usr/include/pd" -DPD -DVERSION='"0.1"' -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O6 -funroll-loops -fomit-frame-pointer -o "filterbank~.o" -c "filterbank~.c"
> exciter.c: In function ‘exciter_properties’:
> exciter.c:352:44: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 352 | sprintf(buf, "pdtk_exciter_dialog %%s %d %d %d %.2f %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 353 | x->x_width, x->x_height, x->x_nbevents, x->x_timegrain, x->x_loop, x->x_save );
> | ~~~~~~~~~~
> | |
> | t_int {aka long int}
> exciter.c:352:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 352 | sprintf(buf, "pdtk_exciter_dialog %%s %d %d %d %.2f %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 353 | x->x_width, x->x_height, x->x_nbevents, x->x_timegrain, x->x_loop, x->x_save );
> | ~~~~~~~~~~~
> | |
> | t_int {aka long int}
> exciter.c:352:50: warning: format ‘%d’ expects argument of type ‘int’, but argument 5 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 352 | sprintf(buf, "pdtk_exciter_dialog %%s %d %d %d %.2f %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 353 | x->x_width, x->x_height, x->x_nbevents, x->x_timegrain, x->x_loop, x->x_save );
> | ~~~~~~~~~~~~~
> | |
> | t_int {aka long int}
> cc -I"/usr/include/pd" -DPD -DVERSION='"0.1"' -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O6 -funroll-loops -fomit-frame-pointer -o "formant~.o" -c "formant~.c"
> cooled~.c: In function ‘cooled_update_block’:
> cooled~.c:241:48: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘t_cooled *’ {aka ‘struct _cooled *’} [-Wformat=]
> 241 | sprintf( x->x_guicommand, "COOLEDIMAGE%x put {%s} -to %d 0\n", x, x->x_gifdata, (bnumber*x->x_zoom)+i );
> | ~^ ~
> | | |
> | unsigned int t_cooled * {aka struct _cooled *}
> cooled~.c: In function ‘cooled_do_update_part’:
> cooled~.c:337:22: warning: assignment to ‘pthread_t’ {aka ‘long unsigned int’} from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
> 337 | x->x_updatechild = NULL;
> | ^
> cooled~.c: In function ‘cooled_loop’:
> cooled~.c:1308:22: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 1308 | char *operator = soperator->s_name;
> | ^~~~~~~~~
> filterbank~.c: In function ‘filterbank_properties’:
> cc -I"/usr/include/pd" -DPD -DVERSION='"0.1"' -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -O6 -funroll-loops -fomit-frame-pointer -o "grid.o" -c "grid.c"
> filterbank~.c:270:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 270 | sprintf(buf, "pdtk_filterbank_dialog %%s %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 271 | x->x_lowfreq, x->x_highfreq );
> | ~~~~~~~~~~~~
> | |
> | t_int {aka long int}
> filterbank~.c:270:50: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘t_int’ {aka ‘long int’} [-Wformat=]
> 270 | sprintf(buf, "pdtk_filterbank_dialog %%s %d %d\n",
> | ~^
> | |
> | int
> | %ld
> 271 | x->x_lowfreq, x->x_highfreq );
> | ~~~~~~~~~~~~~
> | |
> | t_int {aka long int}
> formant~.c: In function ‘formant_gendata’:
> formant~.c:90:9: error: implicit declaration of function ‘error’; did you mean ‘perror’? [-Werror=implicit-function-declaration]
> 90 | error( "formant~ : error generating data : negative or null parameter(s)" );
> | ^~~~~
> | perror
> grid.c: In function ‘grid_new’:
> grid.c:624:27: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
> 624 | if (!strncmp((str = argv[0].a_w.w_symbol->s_name), "grid", 5)
> | ^
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:251: formant~.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/pd-unauthorized_0.1-7_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Reply to: