Re: ocamlopt issue
On Thu, Jun 27, 2002 at 03:47:41PM +0200, J?r?me Marant wrote:
> On Thu, Jun 27, 2002 at 02:54:21PM +0200, Stefano Zacchiroli wrote:
> > On Thu, Jun 27, 2002 at 02:38:08PM +0200, J?r?me Marant wrote:
> > > No, I didn't because it is simply bad practice. We, debian packagers,
> > > must avoid to change configure scripts as much as possible.
> >
> > Not really, many times I've fixed things in distribution tarball and
> > sent it upstream.
> > Is up to you, if you have good dialog with upstream, probably is faster
> > to ask ...
>
> Well, I talking about bad pratices when debian/rules calls autotools,
> and when modifications of the configure.in are local to the package.
Mostly you patch the Makefile/configure script, and the changes appear
in the .diff.gz patch, so you can cut and paste it and send it upstream,
as for example in the advi Makefile :
--- advi-1.0.0+cvs-2002.03.26.orig/Makefile
+++ advi-1.0.0+cvs-2002.03.26/Makefile
@@ -120,17 +120,24 @@
veryclean: clean
rm -f Makefile.config config.cache config.log \
- config.status drawps.ml ttfont.ml config.ml ifdef.ml
+ config.status drawps.ml ttfont.ml config.ml ifdef.ml
drawimage.ml dvicolor.ml
veryveryclean: veryclean
rm -f configure
-installopt:install
-install:: opt doc/splash.dvi
- cp advi.opt ${bindir}/advi
+#installopt:install
+#install:: opt doc/splash.dvi
+installopt:install opt
+ cp ${EXEC}.opt ${bindir}/${EXEC}
+
+installbyte:install byte
+ cp ${EXEC} ${bindir}/${EXEC}
+
+install:: doc/splash.dvi
- mkdir -p $(ADVI_LOC)
cp doc/splash.dvi tex/advilogo.eps tex/caml.eps tex/bar.jpg.eps
tex/*.sty tex/advi.pro $(ADVI_LOC)
if [ -f conf/jpfonts.conf ]; then cp conf/jpfonts.conf
$(ADVI_LOC); fi
+ cp doc/advi.1 ${mandir}/man1
MLFILES = $(addsuffix .ml, $(MODULES))
.depend:: *.mli $(MLFILES) Makefile
Friendly,
Sven Luther
--
To UNSUBSCRIBE, email to debian-ocaml-maint-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: