[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#687643: marked as done (apt-cudf specifies a version number for install requests even when not needed)



Your message dated Fri, 28 Sep 2012 17:32:34 +0000
with message-id <E1THeQU-0002Mi-8O@franck.debian.org>
and subject line Bug#687643: fixed in dose3 3.0.2-2
has caused the Debian Bug report #687643,
regarding apt-cudf specifies a version number for install requests even when not needed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
687643: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=687643
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: apt-cudf
Version: 3.0.2-1
Severity: normal

Dear Maintainer,
   the code that translates EDSP into CUDF in apt-cudf always adds a version
   number to the packages on the request line; this behaviour is
   incorrect, as it prevents the search for relaxed installation
   solutions when apt-cudf-get is used in conjunction with it.

   A patch is attached.

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.5-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages apt-cudf depends on:
ii  aspcud [cudf-solver]  2011.03.17.dfsg-6
ii  libbz2-1.0            1.0.6-4
ii  libc6                 2.13-35
ii  libpcre3              1:8.31-1
ii  mccs [cudf-solver]    1:1.1-2
ii  packup [cudf-solver]  0.6-1
ii  perl                  5.14.2-13
ii  zlib1g                1:1.2.7.dfsg-13

apt-cudf recommends no packages.

apt-cudf suggests no packages.

-- no debconf information
diff --git a/applications/apt-cudf.ml b/applications/apt-cudf.ml
index ffbb872..5ae7fdc 100644
--- a/applications/apt-cudf.ml
+++ b/applications/apt-cudf.ml
@@ -63,27 +63,37 @@ let print_progress ?i msg =
     Format.printf "Message: %s@." msg
 ;;
 
+
+(* Debian specific assumption: only one version of a package 
+   can be installed at a given time.
+   Hence, when a remove request is issued without version constraint,
+   we return (candidate.Cudf.package,None) that designates the only
+   package installed.
+ *)
+
 let make_request tables universe native_arch request = 
   let to_cudf (p,v) = (p,Debian.Debcudf.get_cudf_version tables (p,v)) in
+  let get_candidate (name,constr) = 
+    try
+      List.find 
+	(fun pkg -> 
+	  try (Cudf.lookup_package_property pkg "apt-candidate") = "true"
+	  with Not_found -> false) 
+	(CudfAdd.who_provides universe (name,constr))
+    with Not_found -> 
+      print_error "Package %s does not have a suitable candidate" name
+  in
   let select_packages ?(remove=false) l = 
     List.map (fun ((n,a),c) -> 
       let (name,constr) = Boilerplate.debvpkg ~native_arch to_cudf ((n,a),c) in
-      let candidate = 
-        try
-          List.find (fun pkg ->
-            if request.Edsp.strict_pin then
-              try (Cudf.lookup_package_property pkg "apt-candidate") = "true"
-              with Not_found -> false
-            else
-              true
-          ) (CudfAdd.who_provides universe (name,constr))
-        with Not_found -> 
-          print_error "Package %s does not have a suitable candidate" n
-      in
       if remove then
-        (candidate.Cudf.package,None)
+        (name,None)
       else
-        (candidate.Cudf.package,Some(`Eq,candidate.Cudf.version))
+	match constr, request.Edsp.strict_pin with
+          None, false -> (name, None)
+	| _, _ -> (name,Some(`Eq,(get_candidate (name,constr)).Cudf.version))
+        (* FIXME: when apt will accept version constraints different from `Eq,
+           we will need to pass them through. *)
     ) l 
   in
   if request.Edsp.upgrade || request.Edsp.distupgrade then

--- End Message ---
--- Begin Message ---
Source: dose3
Source-Version: 3.0.2-2

We believe that the bug you reported is fixed in the latest version of
dose3, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 687643@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ralf Treinen <treinen@debian.org> (supplier of updated dose3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 26 Sep 2012 17:21:15 +0200
Source: dose3
Binary: libdose3-ocaml-dev libdose3-ocaml dose-distcheck dose-builddebcheck dose-extra apt-cudf
Architecture: source amd64
Version: 3.0.2-2
Distribution: experimental
Urgency: low
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Ralf Treinen <treinen@debian.org>
Description: 
 apt-cudf   - CUDF solver integration for APT
 dose-builddebcheck - Checks whether build-dependencies can be satisfied
 dose-distcheck - Checks whether dependencies of packages can be satisfied
 dose-extra - Extra QA tools from the Dose3-library
 libdose3-ocaml - OCaml libraries for package dependencies (runtime files)
 libdose3-ocaml-dev - OCaml libraries for package dependencies (development files)
Closes: 680271 685171 687643
Changes: 
 dose3 (3.0.2-2) experimental; urgency=low
 .
   * Patch multiarch-conflicts: fix the translation of conflicts in case of
     multiarchs, a conflict on package p has to apply to p of all possible
     architectures. (closes: #685171). Patch extracted from the
     3.0.2-hotfix branch of the upstream git repository (commit
     a2f69265323d8cead088eeee2a731db582d3cc81). Thanks to Pietro Abate for
     having fixed this.
   * Patch apt-cudf-pinning: Fix version numbers in the package installation
     requests in the translation process from EDSP to CUDF (closes: #687643).
     Thanks to Pietro Abate for the patch!
   * Patch builddebcheck-manpage: Fix architecture options in the
     dose-builddebcheck manpage (closes: #680271).
Checksums-Sha1: 
 5be25f7d57ce3137dd095e91688a281bd3ac5f8a 1841 dose3_3.0.2-2.dsc
 86710b449a9ecc94c5c97345c5f6f1273a801552 17197 dose3_3.0.2-2.debian.tar.gz
 09d6ff1782ab04e91c397b5288b065a4b349f7b9 1077538 libdose3-ocaml-dev_3.0.2-2_amd64.deb
 4243700da72bfa595690e521786b1f9a5345f2b6 11292 libdose3-ocaml_3.0.2-2_amd64.deb
 02754cb14888c2186bc05b9b42f6a827aae7f642 705638 dose-distcheck_3.0.2-2_amd64.deb
 5cbecc3d91c1f1ea77abc1c5ed99815235afa5a6 635276 dose-builddebcheck_3.0.2-2_amd64.deb
 7a4e4d985f46513d5dab63642cb3d657e9075741 1953720 dose-extra_3.0.2-2_amd64.deb
 730c834e590acca46383bce20d6a1032c5d97619 441600 apt-cudf_3.0.2-2_amd64.deb
Checksums-Sha256: 
 0ec2b470a8d747a24a88cc822b8d5e94a8fa1ab6aafadbc15c000e1596bf9c0c 1841 dose3_3.0.2-2.dsc
 f85ae28a3d368b414a88c5485ef9663b66fa45be5655507c5560dde62086e552 17197 dose3_3.0.2-2.debian.tar.gz
 f43c45e8c7848f78cd89b4655e25222e9bc32b224a6476b9ec464fe63e709d89 1077538 libdose3-ocaml-dev_3.0.2-2_amd64.deb
 012a5b16156d4064b5fe9258f25516086cd5fdef958327897130184eabff73b0 11292 libdose3-ocaml_3.0.2-2_amd64.deb
 e65979a388827873e0053024d6d170854ec5043142f16d92f35ccd563b36f10d 705638 dose-distcheck_3.0.2-2_amd64.deb
 49987b63a1de8da535c2903e75fe77a718c5521bcaab2494ccc211dc45734270 635276 dose-builddebcheck_3.0.2-2_amd64.deb
 d5b67626130b213807dcd34e26bd97857d29e3e5dcdac2d83225b324ab20452d 1953720 dose-extra_3.0.2-2_amd64.deb
 9369748747fcb920c0080c457abbfded5991fcc68c347c5c19cb6d24aeb699e4 441600 apt-cudf_3.0.2-2_amd64.deb
Files: 
 8897b369145c72b0460ccb92ba192095 1841 ocaml extra dose3_3.0.2-2.dsc
 72a7b012488341a8eba112ffc5ac2fee 17197 ocaml extra dose3_3.0.2-2.debian.tar.gz
 a4801e7d630ad7c0c1a4aeddc679e60e 1077538 ocaml extra libdose3-ocaml-dev_3.0.2-2_amd64.deb
 84aad87332a508ff3477d48407e96115 11292 ocaml extra libdose3-ocaml_3.0.2-2_amd64.deb
 da4009e201332dcf31463275b0ca6a40 705638 devel extra dose-distcheck_3.0.2-2_amd64.deb
 13b930dc10f1f2d0aea54d1adadc17a2 635276 devel extra dose-builddebcheck_3.0.2-2_amd64.deb
 db1dfad3f0d2cbbcb26807622ba4f757 1953720 devel extra dose-extra_3.0.2-2_amd64.deb
 6d061711d9aac22aa336bb16c20fc075 441600 admin extra apt-cudf_3.0.2-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlBl2swACgkQtzWmSeC6BMH0YACfRVYOP/6z9m6EfPQ784DQ5u1D
qVgAn1mQVJobrExKYfFiFJKWFjDJY6xr
=qFHv
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: