[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1053634: Fix for failing autopkgtest



Source: ocaml-odoc
Version: 2.2.1-1
Severity: normal
Tags: patch
Affects: quilt

Dear Ocaml-Team,

I've uploaded the latest release of quilt, v0.67. In that version, quilt has changed the returned error code of the push and pop commands. If the series file is missing or empty, both commands previously returned the error code 2. Now, the error code in this situation is 1.

In your autopkgtest, you call quilt push and check for the error code 2. However, there is no debian/patches/series in ocaml-odoc, so quilt now returns error code 1 which results in a failing autopkgtest of ocaml-odoc.

This, in turn, results in blocking the testing migration of quilt.

I think it would help to check for the existence of the series file before calling quilt, like in the attached patch.

Please consider applying that patch (or similar code).

Regards,
Tobias
--- a/odoc-on-odoc	2023-10-07 17:22:59.113417298 +0200
+++ b/odoc-on-odoc	2023-10-07 17:22:34.537344295 +0200
@@ -12,7 +12,9 @@
 cd ${outdir}
 
 set +e
-QUILT_PATCHES=debian/patches quilt push -a 2>&1
+if [ -f debian/patches/series ]; then
+        QUILT_PATCHES=debian/patches quilt push -a 2>&1
+fi
 # quilt exit status is 2 when series is already fully applied
 if [ $? -eq 1 ]; then exit 1; fi
 set -e

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: