[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#677146: python-uno uses file from libreoffice-core in preinst without declaring PreDepends



found 677146 1:3.5.4-3
thanks

Hi,

On Mon, Jun 11, 2012 at 11:39:29PM +0200, Rene Engelhard wrote:
> It would have been nice if you could have marked it sanely so that it would
> not block this with other RC and security fixes from migrating:

Ah, nevermind, 3.5.3-5 is an "branch" anyway, so 3.4.5-3 is not marked
as being affected anyway (3.4.1 rcs started from 3.4.5-2) :)

Marking as affecting 3.5.4-3, though I still don't buy the bug.

> > to the policy:
> > 
> >     "Pre-Depends are also required if the preinst script depends on
> >     the named package"
> 
> Seriously I'd like to avoid this.
> 
> Note that the preinst checks whether unopkg is functional:
> 
>   if HOME=$INSTDIR /usr/lib/libreoffice/program/unopkg list --bundled >/dev/null 2>/dev/null; then
>     if [ -e /usr/lib/libreoffice/share/prereg/bundled ] && readlink /usr/lib/libreoffice/share/prereg/bundled 2>&1 >/dev/null && [ -L $d/ure-link ]; then

That doesn't make it *depend* on it. If it doesn't work ("unopkg run fails)
the if is not true -> nothing done.

So I really wonder what's the problem you got...

And that said, the preinst in python-uno is just there to get a sane
upgrade path from python-uno which contained a extension (needs deregistering
to be safe) to one without, thus:

if [ "$1" = "upgrade" ]; then
        if dpkg --compare-versions "$2" lt "1:3.5.2-2"; then
                rm -rf /usr/lib/libreoffice/share/extensions/script-provider-for-python
                sync_extensions
        fi
fi

After that, the stuff is in script-provider-for-python.

(Not for all the other packages, though: [1])

Regards,

Rene

[1]

$ grep sync_extensions *.in
libreoffice-common.postinst.in:                   sync_extensions
libreoffice-mysql-connector.preinst.in: sync_extensions
libreoffice-pdfimport.preinst.in:       sync_extensions
libreoffice-presentation-minimizer.preinst.in:  sync_extensions
libreoffice-presenter-console.preinst.in:       sync_extensions
libreoffice-report-builder.preinst.in:  sync_extensions
libreoffice-script-provider-bsh.preinst.in:     sync_extensions
libreoffice-script-provider-js.preinst.in:      sync_extensions
libreoffice-script-provider-python.preinst.in:  sync_extensions
libreoffice-wiki-publisher.preinst.in:  sync_extensions
python3-uno.preinst.in:         sync_extensions
python-uno.preinst.in:          sync_extensions

> 
> Regards,
> 
> Rene
> 
> 
> 
> -- 
> To UNSUBSCRIBE, email to debian-openoffice-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] 20120611213929.GB9974@rene-engelhard.de">http://lists.debian.org/[🔎] 20120611213929.GB9974@rene-engelhard.de
> 



Reply to: