[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883800: libreoffice-common: Please re-enable the AppArmor profiles



tag 883800 + pending
thanks

Hi,

On Thu, Dec 07, 2017 at 06:47:38PM +0100, intrigeri@debian.org wrote:
> following up on our conversation on #882597, here is a patch series
> that documents how advanced users can adjust the included AppArmor
> profiles to cope with their local setup, and re-enables the AppArmor
> profiles by default.

There's also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883275
but that one has a "fix":
https://anonscm.debian.org/cgit/pkg-openoffice/libreoffice.git/commit/?h=debian-experimental-5.4&id=7af1d9d5b79cc2947106804034d9ecde3ba05d43

> What do you think?

https://anonscm.debian.org/cgit/pkg-openoffice/libreoffice.git/commit/?h=debian-experimental-5.4&id=722c77ba929ae5dee90ca9070a98b294de8ad61f

done already, though in complain mode..

> You mentioned something elsewhere about the LibreOffice test suite
> being possibly affected by this change. Could you please point me at
> an example of this problem? I could investigate. In general, test

I've not *seen* this problem yet, but I can imagine it/foresee it.

> AppArmor policy. Now, runtime tests such as autopkgtests may be
> affected; if needed I could take a look.

Exactly.

From
https://ci.debian.net/data/autopkgtest/unstable/amd64/libr/libreoffice/20171206_231513/log.gz:

[...]
[build JUT] sc_unoapi_6
S=/tmp/autopkgtest-lxc.tpv162wi/downtmp/build.hf5/src && I=$S/instdir &&
W=$S/workdir &&  rm -rf $W/JunitTest/sc_unoapi_6/user && mkdir -p
$W/JunitTest/sc_unoapi_6/user/user && cp
$S/qadevOOo/qa/registrymodifications.xcu
$W/JunitTest/sc_unoapi_6/user/user/ &&
(/usr/lib/jvm/default-java/bin/java -Xmx64M -classpath
"$W/JavaClassSet/JunitTest/sc_unoapi_6:/usr/share/java/junit4.jar:/lib::/usr/lib/libreoffice/program/classes/jurt.jar:/usr/lib/libreoffice/program/classes/test.jar:/usr/lib/libreoffice/program/classes/ScriptProviderForJava.jar:/usr/lib/libreoffice/program/classes/XMergeBridge.jar:/usr/lib/libreoffice/program/classes/xmerge.jar:/usr/lib/libreoffice/program/classes/ridl.jar:/usr/lib/libreoffice/program/classes/test-tools.jar:/usr/lib/libreoffice/program/classes/unoloader.jar:/usr/lib/libreoffice/program/classes/report.jar:/usr/lib/libreoffice/program/classes/unoil.jar:/usr/lib/libreoffice/program/classes/hsqldb.jar:/usr/lib/libreoffice/program/classes/table.jar:/usr/lib/libreoffice/program/classes/smoketest.jar:/usr/lib/libreoffice/program/classes/ScriptFramework.jar:/usr/lib/libreoffice/program/classes/java_uno.jar:/usr/lib/libreoffice/program/classes/ConnectivityTools.jar:/usr/lib/libreoffice/program/classes/query.jar:/usr/lib/libreoffice/program/classes/OOoRunner.jar:/usr/lib/libreoffice/program/classes/sdbc_hsqldb.jar:/usr/lib/libreoffice/program/classes/juh.jar:/usr/lib/libreoffice/program/classes/form.jar:/usr/lib/libreoffice/program/classes/commonwizards.jar"
-Dorg.openoffice.test.arg.env=LD_LIBRARY_PATH"${LD_LIBRARY_PATH+=$LD_LIBRARY_PATH}"
-Dorg.openoffice.test.arg.user=file://$W/JunitTest/sc_unoapi_6/user
-Dorg.openoffice.test.arg.workdir=$W/JunitTest/sc_unoapi_6/user
-Dorg.openoffice.test.arg.postprocesscommand=$S/solenv/bin/gdb-core-bt.sh
-Dorg.openoffice.test.arg.soffice="path:/usr/lib/libreoffice/program/soffice"
-Djava.library.path=/usr/lib/ure/lib
-Dorg.openoffice.test.arg.sce=$S/sc/qa/unoapi/sc_6.sce
-Dorg.openoffice.test.arg.tdoc=$S/sc/qa/unoapi/testdocuments
-Dorg.openoffice.test.arg.xcl=$S/sc/qa/unoapi/knownissues.xcl
org.junit.runner.JUnitCore  org.openoffice.test.UnoApiTest  >
$W/JunitTest/sc_unoapi_6/done.log 2>&1 || (cat
$W/JunitTest/sc_unoapi_6/done.log && echo "to rerun just this failed
test without all others, run:" && echo && echo "    make
JunitTest_sc_unoapi_6" && echo && echo "cd into the module dir to run
the tests faster" && echo "Or to do interactive debugging, run two
shells with:" && echo && echo "    make debugrun" && echo "    make
gb_JunitTest_DEBUGRUN=T JunitTest_sc_unoapi_6" && echo && false))
[...]

Note e.g. the -Dorg.openoffice.test.arg.user. Similar (more like what
was in the bug report in  the first place) for the C++ (Unit)tests which
are not (yet) ran in autopkgtest.

> >From 1afd67ec9f4e68e619f4e707bd62142ba8de78cf Mon Sep 17 00:00:00 2001
> From: intrigeri <intrigeri@boum.org>
> Date: Thu, 7 Dec 2017 17:34:48 +0000
> Subject: [PATCH 1/2] * debian/README.Debian: document how to debug and
>  customize the included AppArmor profiles
[...]

Applied.

> >From 070fba71b11f1fb6ebc4e229f50c18ff53deea52 Mon Sep 17 00:00:00 2001
> From: intrigeri <intrigeri@boum.org>
> Date: Thu, 7 Dec 2017 17:35:13 +0000
> Subject: [PATCH 2/2] enable the AppArmor profiles back
[...]

Obsolete :-)

Regards,

Rene


Reply to: