[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#935052: marked as done (graphite2: FTBFS on hurd-i386)

Your message dated Thu, 17 Oct 2019 14:22:38 +0200
with message-id <20191017122237.GS24920@mapreri.org>
and subject line Fixed: graphite2: FTBFS on hurd-i386
has caused the Debian Bug report #935052,
regarding graphite2: FTBFS on hurd-i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
935052: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935052
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: graphite2
Version: 1.3.13-7
Severity: important
Tags: ftbfs, patch
User: debian-hurd@lists.debian.org
Usertags: hurd

Hello,

Currently graphite2 FTBFS on GNU/Hurd due to one failing test
awamicmp3. The attached patch tests_CMakeLists.txt.diff omits that test
for Hurd printing a warning instead. Additionally the patch non-
linux.diff is commented out reducing the number of tests by 2 (don't
know which ones of 93). Attached is an updated version of that patch
too.

Thanks!

Index: graphite2-1.3.13/tests/CMakeLists.txt
===================================================================
--- graphite2-1.3.13.orig/tests/CMakeLists.txt
+++ graphite2-1.3.13/tests/CMakeLists.txt
@@ -121,4 +121,8 @@ cmptest(annacmp1 Annapurnarc2.ttf udhr_n
 cmptest(schercmp1 Scheherazadegr.ttf udhr_arb.txt -r)
 cmptest(awamicmp1 Awami_test.ttf awami_tests.txt -r -e 1)
 cmptest(awamicmp2 Awami_compressed_test.ttf awami_tests.txt -r -e 1)
-cmptest(awamicmp3 Awami_compressed_test2.ttf awami_tests.txt -r -e 1)
+if  (${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
+  message("UNRESOLVED: Test awamicmp3 fails on: " ${CMAKE_SYSTEM_NAME})
+else()
+  cmptest(awamicmp3 Awami_compressed_test2.ttf awami_tests.txt -r -e 1)
+endif()

Index: graphite2-1.3.13/src/CMakeLists.txt
===================================================================
--- graphite2-1.3.13.orig/src/CMakeLists.txt
+++ graphite2-1.3.13/src/CMakeLists.txt
@@ -102,7 +102,7 @@ set_target_properties(graphite2 PROPERTI
                                             LT_VERSION_REVISION ${GRAPHITE_API_REVISION}
                                             LT_VERSION_AGE ${GRAPHITE_API_AGE})
 
-if  (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+if  (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
     set_target_properties(graphite2 PROPERTIES
         COMPILE_FLAGS   "-Wall -Wextra -Wno-unknown-pragmas -Wendif-labels -Wshadow -Wctor-dtor-privacy -Wnon-virtual-dtor -fno-rtti -fno-exceptions -fvisibility=hidden -fvisibility-inlines-hidden -ffloat-store"
         LINK_FLAGS      "-nodefaultlibs ${GRAPHITE_LINK_FLAGS}"
@@ -129,7 +129,7 @@ if  (${CMAKE_SYSTEM_NAME} STREQUAL "Linu
     endif ()
     set(CMAKE_CXX_IMPLICIT_LINK_LIBRARIES "")
     CREATE_LIBTOOL_FILE(graphite2 "/lib${LIB_SUFFIX}")
-endif()
+endif (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
 
 if  (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin")
     set_target_properties(graphite2 PROPERTIES
Index: graphite2-1.3.13/tests/examples/CMakeLists.txt
===================================================================
--- graphite2-1.3.13.orig/tests/examples/CMakeLists.txt
+++ graphite2-1.3.13/tests/examples/CMakeLists.txt
@@ -23,12 +23,12 @@ macro(test_example TESTNAME SRCFILE)
     set_tests_properties(${TESTNAME} PROPERTIES TIMEOUT 3)
 endmacro()
 
-if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
     find_package(Freetype)
     if (${FREETYPE_FOUND})
         include_directories(${FREETYPE_INCLUDE_DIRS})
     endif()
-endif()
+endif (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
 
 macro(test_freetype TESTNAME SRCFILE)
     if (${FREETYPE_FOUND})
Index: graphite2-1.3.13/tests/vm/CMakeLists.txt
===================================================================
--- graphite2-1.3.13.orig/tests/vm/CMakeLists.txt
+++ graphite2-1.3.13/tests/vm/CMakeLists.txt
@@ -29,12 +29,12 @@ if  (CMAKE_COMPILER_IS_GNUCXX OR CMAKE_C
 	target_link_libraries(vm-test-direct vm-test-common)
 endif()
 
-if  (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+if  (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
 	add_definitions(-fno-rtti -fno-exceptions)
 	if ("${CMAKE_BUILD_TYPE}" STREQUAL "Release")
 		add_definitions(-DNDEBUG -fomit-frame-pointer)
 	endif()
-endif()
+endif  (${CMAKE_SYSTEM_NAME} STREQUAL "Linux" OR ${CMAKE_SYSTEM_NAME} MATCHES "k.*BSD" OR ${CMAKE_SYSTEM_NAME} STREQUAL "GNU")
 
 add_test(vm-test-call-threading vm-test-call ${testing_SOURCE_DIR}/fonts/small.ttf 1)
 set_tests_properties(vm-test-call-threading PROPERTIES

--- End Message ---
--- Begin Message --- 
Version: 1.3.13-10

Well, I don't know what happened, but starting with this version it
builds again on hurd, so I'm closing this bug.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


--- End Message ---
Reply to: