--- Begin Message ---
Source: hunspell
Version: 1.7.0-3
Severity: serious
Tags: ftbfs bookworm sid patch
Your package FTBFS in unstable, here is the relevant part of my build
log:
,----
| g++ -DHAVE_CONFIG_H -I. -I../.. -I../../src/hunspell -I../../src/hunspell -I../../src/parsers -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -ffile-prefix-map=/usr/local/src/deb-src/hunspell/hunspell=. -fstack-protector-strong -Wformat -Werror=format-security -c -o munch.o munch.cxx
| hunspell.cxx: In function 'char* scanline(char*)':
| hunspell.cxx:584:9: error: format not a string literal and no format arguments [-Werror=format-security]
| 584 | printw(message);
| | ~~~~~~^~~~~~~~~
`----
This happened because ncurses added format attributes to several
functions, and dpkg-buildpackage defaults to -Werror=format-security.
For details about the ncurses change, see #993179.
I have attached a simple patch which could be added to the series in
debian/patches, but there are also a few warnings which might be worth
looking at.
From 91148a568c5994768e660ca5a968df16ae4a146c Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenjoac@gmx.de>
Date: Wed, 20 Oct 2021 19:40:36 +0200
Subject: [PATCH] Fix string format error with recent ncurses
---
src/tools/hunspell.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/tools/hunspell.cxx b/src/tools/hunspell.cxx
index 690e34a..b165634 100644
--- a/src/tools/hunspell.cxx
+++ b/src/tools/hunspell.cxx
@@ -581,7 +581,7 @@ const char* basename(const char* s, char c) {
#ifdef HAVE_CURSES_H
char* scanline(char* message) {
char input[INPUTLEN];
- printw(message);
+ printw("%s", message);
echo();
getnstr(input, INPUTLEN);
noecho();
--
2.33.0
--- End Message ---
--- Begin Message ---
Source: hunspell
Source-Version: 1.7.0-4
Done: Rene Engelhard <rene@debian.org>
We believe that the bug you reported is fixed in the latest version of
hunspell, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 996918@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Rene Engelhard <rene@debian.org> (supplier of updated hunspell package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 20 Oct 2021 20:36:34 +0200
Source: hunspell
Architecture: source
Version: 1.7.0-4
Distribution: unstable
Urgency: medium
Maintainer: Debian LibreOffice Maintainers <debian-openoffice@lists.debian.org>
Changed-By: Rene Engelhard <rene@debian.org>
Closes: 996918
Changes:
hunspell (1.7.0-4) unstable; urgency=medium
.
[ Debian Janitor ]
* Remove constraints unnecessary since stretch:
+ libhunspell-dev: Drop versioned constraint on hunspell in Replaces.
+ hunspell-tools: Drop versioned constraint on hunspell in Replaces.
.
[ Mattia Rizzolo ]
* Remove constraints unnecessary since quite a long time:
+ libmyspell-dev: Drop Conflicts/Replaces.
* Bump d/watch to version=4 and use subst.
.
[ Rene Engelhard ]
* debian/patches/Fix-string-format-error-with-recent-ncurses.diff:
add patch from Sven Joachim; as name says (closes: #996918)
Checksums-Sha1:
af326f3fd9efd2bc05921461317fcd06e4d24774 2257 hunspell_1.7.0-4.dsc
52c489b98b52155872b11e1fb4e41550a13f5279 21952 hunspell_1.7.0-4.debian.tar.xz
249cb9b040107c055fcea2d14a5d5b0d38a13eb3 6389 hunspell_1.7.0-4_source.buildinfo
Checksums-Sha256:
5ac1010098cc6b0fca45a7d6126f699ff1993b7b5ad994a0c70cd244be5b9e43 2257 hunspell_1.7.0-4.dsc
c3630663baf70c6d1e6ffb6fe2a4ec5cd4325b753a44036c8d1b78d7cd46adf5 21952 hunspell_1.7.0-4.debian.tar.xz
5c8d9128221a9df52cb6a02b35de5af3671c07554a5165b65e580b4aa87108d3 6389 hunspell_1.7.0-4_source.buildinfo
Files:
16491d975e4cb3725895b8e4e75db057 2257 text optional hunspell_1.7.0-4.dsc
4cd35b56dd427cc998f968f522db50ee 21952 text optional hunspell_1.7.0-4.debian.tar.xz
420073b0f0bef1564f5914a695b5169e 6389 text optional hunspell_1.7.0-4_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCgAuFiEE4S3qRnUGcM+pYIAdCqBFcdA+PnAFAmFwYkwQHHJlbmVAZGVi
aWFuLm9yZwAKCRAKoEVx0D4+cOnAEADj11WS+p2uChVecuZJFUXQ/NUT7hCjj8af
4f3eij8a6/iipBpXOwowu6UWaEGb67WKHjC+hBSdN4Z+rM4kWreQviIQfni+JbMA
6+7TkIjKraL2MIiHGg2Vgl5oY2/B9MEFUxS6zVmIIpRFjnDq6RB7qfRjiojkeWyE
3yexoK5KHcRxUes8BoDrhT7y3Or0U3PVqpBat7vsU+FBl3afvWEkcFbmcbzlF9ma
hLyao5KMGPK7yN50VlM+5OG+kU+HNHk+L3vL/7D9Yhiqr2RpqFOw3G+cNjojc0hk
K06Ktgwysesbu8oKGkmWp6m/zCYLfbgsxDfW4TkU5/t7k3JAh+Bn29+CHmO8uPVI
Icvw8EpodDMDjAg4NHj7gAoaKW1C8jybGEXSWaA+LmZGjDgWcGB17yoncYrl27VH
PQaxwP+SSj2NCU+fBjzX2fquM8a/PrZyg2alnV/kmouuP8VUkTtrFLrM9vUGIL1D
3RCRWhhcWSa1fp9ueCIeHjEdTpFgoyZs+CiU1rv0q2ijh/STCNtV+HD8Qmb+wbKq
K9xqKnwXwhyJchwZqmSiQfVJOh0Xt8MflyKiaTOeCH0aivkamz7+9cq0wFjf8s4h
4HtUGde5yL8Fq0oIrceHrWnf1htiyB/3Ytwt8LnsEkCn+fDwBOcZp3r3a0TQE0dH
0XZ6vFdhEg==
=P4hU
-----END PGP SIGNATURE-----
--- End Message ---