[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: python-social-auth 0.2.19-1 review



Hi Tiago,

On Tue, 2016-05-17 at 02:14 -0300, Tiago Ilieve wrote:
> In my first task as a member of the Debian Python Modules Team, I've
> prepared an upload of "python-social-auth"[1]. It was updated to a
> newer upstream release (0.2.13 to 0.2.19) and some fixes were also
> done.
> 
> Is there anyone here able to review/sponsor those changes?

my quick review after building it:

- lintian complains about site/js/bootstrap.min.js, AFAIKT the "site"
folder  contains the project's website. Maybe you would like to remove
it by repacking the source tarball.
- You could shorten "python-all (>= 2.7~)" from Build-Depends to
"python-all".
- It's more accurate to use "Expat" instead of "MIT" in d/copyright.
- Both binary packages ship the documentation. While it's only a few KB
it would be an option to move the documentation to a separate binary
package.

Cheers and thanks for your work!
-- 
Michael Fladischer
Fladi.at

Attachment: signature.asc
Description: This is a digitally signed message part

Attachment: smime.p7s
Description: S/MIME cryptographic signature


Reply to: