Re: a review of your bumblebee-status package

[Julian Gilbey <julian@d-and-j.net>]

On Tue, Jun 07, 2022 at 09:47:14AM -0400, Antoine Beaupré wrote:
> >>> _version.py is not a copy of versioneer, it's *generated* by versioneer.
> >>> However, there is versioneer.py in the root directory, which is. I'll
> >>> exclude that from the source and repack.
> >> 
> >> hmm... how about that generated file though? shouldn't it be ... well,
> >> generated at build time instead? :)
> >
> > As far as I understand it, this file is used by the author of the 
> > program, not end users. I don't understand it well, though, because I 
> > haven't put much time into researching what versioneer even does.
> > If my hunch is correct, I may be able to just remove the file from the 
> > source altogether, but I haven't tried that yet.
> 
> Well, it's used by the program to show the version info, so it's
> *eventually* used by users for sure.
> 
> I think just removing the file is a good first guess.

Removing the file is a bad idea!  Replacing it with the PyPI version
(through debian/patches) is a much better approach.  (And possibly
excluding the file in debian/copyright as well.)

   Julian